This repository has been archived by the owner on Mar 24, 2020. It is now read-only.
Title sorting ignores quotes and case #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcritchlow
force-pushed
the
feature/solr-title-searching
branch
from
135e2bf
to
6c591ff
Compare
mcritchlow
force-pushed
the
feature/solr-title-searching
branch
3 times, most recently
from
6010a7c
to
6563ea3
Compare
- creates an alphaStrippedSort fieldtype which removes double quotes, filters case-sensitivity, whitespace, etc. - explicitly declares title_ssi as a solr field of type alphaStrippedSort for use in sorting
mcritchlow
force-pushed
the
feature/solr-title-searching
branch
from
6563ea3
to
feb7500
Compare
|
@gamontoya - does the screenshot above look like what you'd expect for sorting? |
mcritchlow
changed the title
|
@mcritchlow Yes, right on! |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #661
MERGED
NOTE: There will need to be an accompanying PR againstdams4-solrwith theseschema.xmlchanges. I haven't put that up yet, because I'd like feedback from the team on this approach before doing so. This will require a full reindex, so we want to get this right the first time, ideally..Local Checklist
masterbranch?What does this PR do?
alphaStrippedSortfieldtypewhich ignores double quotes/single quotes, and parens (for now), and filters case-sensitivitytitle_ssias a field of typealphaStrippedSortfor use insorting instead of the default tokenizer/filters applied when analyzing
title_ssiWhy are we doing this? Any context of related work?
References #661
Screenshots
@ucsdlib/developers - please review