Broken HTML in Fyyur project

[ghost]

I just cloned this and set up the development server for the Fyyur project. The create artist form seems broken:

Screenshot of the bottom:

Probably related: the Genre and Facebook Link fields are both returned as 'state' in the ImmutableDict object.

[PlessioTihsrah]

Remove "id=form.state attribute" from the tags which are broken

[nickever]

I've submitted a pull request to fix this. #54

I also noticed that the facebook link label had the 'for' attribute of "genre", so I've requested to change that too.

[omar-yehia]

in new_artist.html
the "genre" form and "facebook_link" form has wrong id , id=form.state :D
change the id to "genre", and "facebook_link" , and don't forget to edit the (label) for "facebook_link"

[omar-yehia]

after the edits

      <div class="form-group">
        <label for="genres">Genres</label>
        <small>Ctrl+Click to select multiple</small>
        {{ form.genres(class_ = 'form-control', placeholder='Genres, separated by commas', id='genres', autofocus = true) }}
      </div>
      <div class="form-group">
          <label for="facebook_link">Facebook Link</label>
          {{ form.facebook_link(class_ = 'form-control', placeholder='http://', id='facebook_link', autofocus = true) }}
      </div>

[zemelb]

T

after the edits

      <div class="form-group">
        <label for="genres">Genres</label>
        <small>Ctrl+Click to select multiple</small>
        {{ form.genres(class_ = 'form-control', placeholder='Genres, separated by commas', id='genres', autofocus = true) }}
      </div>
      <div class="form-group">
          <label for="facebook_link">Facebook Link</label>
          {{ form.facebook_link(class_ = 'form-control', placeholder='http://', id='facebook_link', autofocus = true) }}
      </div>

Thank you! Can't believe they haven't fixed this yet...

[jackwu413]

When will this be resolved? I see that @nickever submitted a PR for the fix on May 14.

[zemelb]

Doubt it ever will be. Udacity hasn’t shown any willingness to fix problems with their course materials.

…

-Brandon This message sent from my iPhone

On Sep 26, 2020, at 9:56 AM, Jack Wu ***@***.***> wrote:  When will this be resolved? I see that @nickever submitted a PR for the fix on May 14. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[jackwu413]

Wow. That's extremely disappointing. Guess this'll be the first and last Udacity course that I pay for.

[themagiccog]

I am not happy with the way Udacity has set up thier courses. There are a lot of errors and inconsistencies with the codes. And no effort is made to clean up. Hopefully it gets better. I just started the course and I had this same issue.

[zemelb]

It only gets worse as you go on, and their customer service doesn’t care. I ended up disputing the charge with my credit card company because their “support” wouldn’t even bother replying to my emails.

…

On Oct 16, 2020, at 11:56 PM, COG Gbugu ***@***.***> wrote:  I am not happy with the way Udacity has set up thier courses. There are a lot of errors and inconsistencies with the codes. And no effort is made to clean up. Hopefully it gets better. I just started the course and I had this same issue. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[robinlamb]

I also made a pull request fixing this, as well as adding the missing fields to the pages. #117

[SudKul]

Fixed in the #117