Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken form on 'create artist' page #54

Closed
wants to merge 1 commit into from

Conversation

nickever
Copy link

Removed 'id=form.state' attribute to fix broken display of genre and facebook link form
Corrected error in 'for' attribute for facebook label.

Removed 'id=form.state' attribute to fix broken display of genre and facebook link form
Corrected error in 'for' attribute for facebook label.
@nickever
Copy link
Author

This same fix is also required for new_venues.html

@dolugen
Copy link

dolugen commented May 18, 2020

You beat me to it 👍

@mohannadize
Copy link

The file projects/01_fyyur/starter_code/templates/forms/new_venue.html has the same issue.

@bc-maia
Copy link

bc-maia commented Oct 11, 2020

hello! have found this problem and after sometime this fix, it worked for me too, but it should already be merged so new students wouldn't lose time looking for some problem which's not original from their code.

@SudKul
Copy link
Contributor

SudKul commented Mar 16, 2021

Hi @nickever
Thanks for suggesting the update to the starter code. Your proposed updates have already been merged in #117
We appreciate your contribution.

@SudKul SudKul closed this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants