Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have completed the major requirements for the Fyyur project, and I have made some updates to the starter code based on some issues I encountered while working on the project:
app.py
Reorganize the controllers and give each controller a distinct heading to make it easier to find each distinct route. I noticed that the
/venues/<int:venue_id>/edit
controllers where not listed with the other/venues/
controllers, and the/artists/create
controller was listed after the/artists/<int:artist_id>/edit
controller. I moved those around and made sure that the ordering was the same for both venues and artists. I also added headers for each separate controller so that finding a specific route to work on would be easier.Adjust main section headers. This isn't really a necessary edit, but for me it helps keep the main sections and subsections clearly identified and feels cleaner.
/templates/forms/
new_venue
,edit_venue
,new_artist
,edit_artist
. All of these forms were missing several fields and were not rendering correctly, and since completing these forms was not listed as one of the requirements for completion I went ahead and edited these forms.forms.py
VenueForm
andArtistForm
. Several attributes were missing and causing the app to crash. I added the missing attributes and added the missing import forBooleanField
. Again, since this file was not specifically marked as one needing revision to complete the project, I made the edits so other students won't encounter issues.I hope the edits are useful and that I have appropriately explained the rationale behind them. If there is anything you would suggest changing, please let me know. Thank you!