Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deletebackword list #3064

Closed
wants to merge 3 commits into from

Conversation

felixfeng33
Copy link
Collaborator

before

before.mp4

after

after.mp4

Copy link

changeset-bot bot commented Mar 25, 2024

🦋 Changeset detected

Latest commit: 954c1af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@udecode/plate-indent-list Patch
@udecode/plate Patch
@udecode/plate-serializer-docx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 9:45am

@OliverWales
Copy link
Collaborator

@felixfeng33 does this fix the case in #2596 too? I.e. pressing backspace on a node with text in it moves it into the bullet point rather than deleting it?

@12joan
Copy link
Collaborator

12joan commented Mar 26, 2024

@OliverWales We're discussing this on Discord (and I've also posted about it on Slack) if you want more context about why this happens. The current plan is to implement a fix for this in Slate.

The root cause of the issue is this rule in Slate's mergeNodes: https://github.com/ianstormtaylor/slate/blob/main/packages/slate/src/transforms-node/merge-nodes.ts#L131-L143

@zbeyens zbeyens marked this pull request as draft March 28, 2024 07:37
@felixfeng33
Copy link
Collaborator Author

felixfeng33 commented Apr 12, 2024

Slate issue has been fixed. Plate's issue plan to fixed on the next Sunday

@felixfeng33
Copy link
Collaborator Author

continue by #3140
need update slate version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants