Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge empty prev nodes for list item and blockquote #3140

Merged
merged 8 commits into from Apr 23, 2024
Merged

Conversation

felixfeng33
Copy link
Collaborator

Description
fixes #2596
fixes #2692

and fixes

before.mp4
after.mp4

Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: 93c590c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@udecode/plate-block-quote Patch
@udecode/plate-indent-list Patch
@udecode/plate-basic-elements Patch
@udecode/plate Patch
@udecode/plate-serializer-md Patch
@udecode/plate-serializer-docx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 0:01am

Copy link
Member

@zbeyens zbeyens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

packages/block-quote/src/withBlockQuote.ts Outdated Show resolved Hide resolved
@zbeyens zbeyens changed the title The behivor abnormal when deleting back to empty list item or quote Merge empty prev nodes for list item and blockquote Apr 22, 2024
@felixfeng33
Copy link
Collaborator Author

The CI is acting up. How to clean the cache?

@12joan
Copy link
Collaborator

12joan commented Apr 22, 2024

It's a capitalisation issue. withBlockQuote is spelled like that in some places and withBlockquote in others. Some file systems don't care about this, but GitHub's runners do.

@zbeyens
Copy link
Member

zbeyens commented Apr 22, 2024

You can also run yarn g:brl

@felixfeng33
Copy link
Collaborator Author

It seems like a caching issue, I can resolve it locally.

@felixfeng33
Copy link
Collaborator Author

waiting for my confirm

@felixfeng33
Copy link
Collaborator Author

done

@12joan
Copy link
Collaborator

12joan commented Apr 22, 2024

Nice! I'm not sure what solution you found, but for future reference, this is the command I usually use for fixing filename case issues.

git mv src/somefile.ts src/someFile.ts

@felixfeng33
Copy link
Collaborator Author

Nice! I'm not sure what solution you found, but for future reference, this is the command I usually use for fixing filename case issues.

git mv src/somefile.ts src/someFile.ts

Thank you Joe.This command is more efficient than mine solution.

@felixfeng33
Copy link
Collaborator Author

@zbeyens Why not merge?

@zbeyens zbeyens merged commit 1bea0ce into main Apr 23, 2024
6 checks passed
@zbeyens zbeyens deleted the fix/shouldMergePrev branch April 23, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants