This repository has been archived by the owner on Apr 18, 2022. It is now read-only.
feat(spy): Adds argument support for function calls #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was recently using this library in a small Deno project and found that the typing on function calls was a bit lacking and was causing some TS errors since I would pass a function that required multiple arguments, but the returned type only ever had 1 listed.
Contents
I've upgraded the overload responsible for function call spying to include some defaults to the values, as well as to more strongly type the returned function. Similarly, I've added a test to specifically check that returned noted function signature carries over to the spied counterpart, e.g. a function of type
(a: number: b: string) => number
should have an equivalent signature when run through thespy()
function.Test Results
Full test results can be included if needed, but I believe the summary should hopefully be enough.