Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds Sendgrid email support #466

Merged
merged 3 commits into from
Dec 14, 2021
Merged

adds Sendgrid email support #466

merged 3 commits into from
Dec 14, 2021

Conversation

mdwallick
Copy link
Contributor

This is a very simple change to add Sendgrid support for emails.

shawnrecinto-okta
shawnrecinto-okta previously approved these changes Nov 18, 2021
View reviewed changes
Copy link

@shawnrecinto-okta shawnrecinto-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follows thew same pattern as what we have for Sparkpost and AWS API
@noinarisak could you take a peek too?

@noinarisak noinarisak self-requested a review November 18, 2021 20:35
noinarisak
noinarisak requested changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@noinarisak noinarisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdwallick Can you also update README to represent the new addition! Btw, great addition!

@noinarisak noinarisak added the type: feature New feature or request label Nov 18, 2021
@noinarisak noinarisak self-assigned this Nov 18, 2021
@noinarisak
Copy link
Contributor

Maybe one of these days, I create Adapter pattern to enable more Email Providers.

@mdwallick
Copy link
Contributor Author

I added Sendgrid documentation to the README.

@noinarisak
Copy link
Contributor

Thanks for the README update, @mdwallick!

Looks like the build failed due to our linting check. 😉 Can you run flake8 locally or review the build log and correct the issue and re-push the PR? Ping me on Slack if you need help.

@sonarcloud
Copy link

sonarcloud bot commented Dec 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@mdwallick
Copy link
Contributor Author

I've fixed the linting errors. My bad for not checking that first.

@noinarisak
Copy link
Contributor

Thanks @mdwallick 🌮 🎉 !!!

@noinarisak noinarisak merged commit 5937278 into udplabs:master Dec 14, 2021
@mdwallick mdwallick deleted the feature-sendgrid-support branch January 11, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noinarisak noinarisak noinarisak approved these changes

@shawnrecinto-okta shawnrecinto-okta shawnrecinto-okta left review comments

Assignees

@noinarisak noinarisak

Labels
type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdwallick @noinarisak @shawnrecinto-okta