Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/demo buttons #475

Merged
merged 6 commits into from
Jan 26, 2022
Merged

Feature/demo buttons #475

merged 6 commits into from
Jan 26, 2022

Conversation

anushrav
Copy link
Contributor

Disabled Id Verification and MFA enrolment button in GlobalComponets

@srecinto srecinto self-requested a review January 26, 2022 18:02
@srecinto srecinto added the type: feature New feature or request label Jan 26, 2022
srecinto
srecinto requested changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@srecinto srecinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the buttons look disabled and possibly put "(Disabled)" in the text?

@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

srecinto
srecinto approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@srecinto srecinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@srecinto srecinto merged commit 9fcd160 into udplabs:master Jan 26, 2022
@anushrav anushrav deleted the feature/demo-buttons branch January 26, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srecinto srecinto srecinto approved these changes

Assignees
No one assigned
Labels
type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anushrav @srecinto