Skip to content

Commit

Permalink
Fix sign_in usage (#487)
Browse files Browse the repository at this point in the history
`sign_in` should take claims map and opts keyword list as two separate arguments, s. https://github.com/ueberauth/guardian/blob/master/lib/guardian/plug.ex#L76 and https://github.com/ueberauth/guardian/blob/master/lib/guardian/plug.ex#L176.

Not sure about `sign_out`, but I think it only takes opts and no claims https://github.com/ueberauth/guardian/blob/master/lib/guardian/plug.ex#L79 so that call has to be changed to `conn = MyApp.Guardian.Plug.sign_out(conn, resource, opts)`.
  • Loading branch information
bcat-eu authored and doomspork committed Mar 27, 2018
1 parent 086c9e9 commit 754e767
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions upgrade_guides/0.14.to.1.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -182,13 +182,13 @@ When working with plugs, `sign_in`/`sign_out` are still with us but instead of u

0.14.x
```elixir
conn = Guardian.Plug.sign_in(conn, resource, [token_type, claims])
conn = Guardian.Plug.sign_in(conn, resource, token_type, claims)
conn = Guardian.Plug.sign_out(conn, token, [claims_to_check])
```

1.0
```elixir
conn = MyApp.Guardian.Plug.sign_in(conn, resource, [claims, opts])
conn = MyApp.Guardian.Plug.sign_in(conn, resource, claims, opts)
conn = MyApp.Guardian.Plug.sign_out(conn, resource, [claims_to_check, opts])
```

Expand Down

0 comments on commit 754e767

Please sign in to comment.