-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade phoenix and jose #205
Conversation
@aaronjensen doesn't look like Jose was updated in your changes. |
We should also consider bumping the Elixir version to 1.2: https://github.com/ueberauth/guardian/blob/master/mix.exs#L18 |
4d0554f
to
fd6fe14
Compare
@doomspork I had only updated in the |
Looks like we'll need to update the TravisCI configuration for this too. Sorry for the back-and-forth @aaronjensen, would you be willing to make a change to This will drop testing for Elixir 1.1 and OTP 17. language: elixir
elixir:
- 1.2.5
- 1.3.4
otp_release:
- 18.3
- 19.0
env: MIX_ENV=test
sudo: false # faster builds
notifications:
email: false
script:
- mix compile --warnings-as-errors
- mix test
- mix credo |
b7404a0
to
a20f6d7
Compare
@doomspork sure thing, how's that? |
It looks like Elixir 1.2.5 and OTP 19 don't work well together. Want me to remove the old elixir? I think there's a travis syntax for more specific matrixing but I don't know it off the top of my head. |
@aaronjensen after playing with it a bit tonight, I believe this is what we need: language: elixir
matrix:
include:
- otp_release: 18.3
elixir: 1.3.2
- otp_release: 19.0
elixir: 1.3.2
sudo: false
script:
- mix test |
a20f6d7
to
3537c1a
Compare
I added elixir 1.2 in there as well, let's see how it goes. |
@@ -15,7 +15,7 @@ defmodule Guardian.Mixfile do | |||
name: "Guardian", | |||
app: :guardian, | |||
version: @version, | |||
elixir: "~> 1.1", | |||
elixir: "~> 1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaronjensen I think we can safely drop 1.2 in favor of 1.3 now that 1.4 is preparing to ship. I've gone ahead and updated the rest of the projects within the Ueberauth organization. |
3537c1a
to
10216f5
Compare
Sounds good, updated. |
@aaronjensen I pulled your branch, updated the I've released a new version as well. |
Phoenix so we can use it in projects that use phoenix 1.2 w/o override and jose so we can build it with recent elixir/erlang versions