Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade phoenix and jose #205

Closed
wants to merge 4 commits into from

Conversation

aaronjensen
Copy link
Contributor

@aaronjensen aaronjensen commented Sep 21, 2016

Phoenix so we can use it in projects that use phoenix 1.2 w/o override and jose so we can build it with recent elixir/erlang versions

@doomspork
Copy link
Member

@aaronjensen doesn't look like Jose was updated in your changes.

@doomspork
Copy link
Member

We should also consider bumping the Elixir version to 1.2: https://github.com/ueberauth/guardian/blob/master/mix.exs#L18

@aaronjensen
Copy link
Contributor Author

@doomspork I had only updated in the mix.Iock. I updated it in the mix.exs as well and bumped phoenix.

@doomspork
Copy link
Member

Looks like we'll need to update the TravisCI configuration for this too. Sorry for the back-and-forth @aaronjensen, would you be willing to make a change to .travis.yml?

This will drop testing for Elixir 1.1 and OTP 17.

language: elixir
elixir:
  - 1.2.5
  - 1.3.4
otp_release:
  - 18.3
  - 19.0 
env: MIX_ENV=test
sudo: false # faster builds
notifications:
  email: false
script:
  - mix compile --warnings-as-errors
  - mix test
  - mix credo

@aaronjensen aaronjensen force-pushed the upgrade-phoenix branch 3 times, most recently from b7404a0 to a20f6d7 Compare September 21, 2016 17:45
@aaronjensen
Copy link
Contributor Author

@doomspork sure thing, how's that?

@aaronjensen
Copy link
Contributor Author

It looks like Elixir 1.2.5 and OTP 19 don't work well together. Want me to remove the old elixir? I think there's a travis syntax for more specific matrixing but I don't know it off the top of my head.

@doomspork
Copy link
Member

@aaronjensen after playing with it a bit tonight, I believe this is what we need:

language: elixir
matrix:
  include:
    - otp_release: 18.3
      elixir: 1.3.2
    - otp_release: 19.0
      elixir: 1.3.2
sudo: false
script:
  - mix test

@aaronjensen
Copy link
Contributor Author

I added elixir 1.2 in there as well, let's see how it goes.

@@ -15,7 +15,7 @@ defmodule Guardian.Mixfile do
name: "Guardian",
app: :guardian,
version: @version,
elixir: "~> 1.1",
elixir: "~> 1.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After conferring with @hassox and @scrogson, we're going to bump this to 1.3 and drop 1.2

@doomspork
Copy link
Member

@aaronjensen I think we can safely drop 1.2 in favor of 1.3 now that 1.4 is preparing to ship. I've gone ahead and updated the rest of the projects within the Ueberauth organization.

@aaronjensen
Copy link
Contributor Author

Sounds good, updated.

@doomspork
Copy link
Member

@aaronjensen I pulled your branch, updated the .travis.yml and targeted 1.3, and pushed to master. Thanks again 👍

I've released a new version as well.

@doomspork doomspork closed this Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants