Upgrade Ueberauth and Refactor CSRF State Logic #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for the support! Appreciate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ueberauth 0.7.0 introduces automatic CSFR attack protection: ueberauth/ueberauth#136. This conflicts with the current way that this library fetches the CSRF state parameter.
Ueberauth exposes helper functions to pull the state param from the correct location: https://hexdocs.pm/ueberauth/Ueberauth.Strategy.Helpers.html#with_state_param/2. I've replaced the current method with this helper.
I've also updated some of the tests to be compatible with the new CSRF protection.