New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace node-sass with dart sass and fix deprecation warning #1590

Merged

hanspagel merged 1 commit into ueberdosis:main from mmachatschek:replace_nodesass

Jul 14, 2021

Contributor

mmachatschek commented Jul 14, 2021

The deprecation warning shown in the console is triggered by using the "old" way to divide to values.

https://sass-lang.com/documentation/breaking-changes/slash-div

node-sass was replace by sass at it's recommended to upgrade to the maintained version. The readme of the node-sass says:

Warning: LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases indefinitely, there are no plans to add additional features or compatibility with any new CSS or Sass features. Projects that still use it should move onto Dart Sass.


          Replace node-sass with dart sass and fix deprecation warning

47c2f6a

Contributor

hanspagel commented Jul 14, 2021

OMG, this is amazing. This also makes it work with Node 16. Thanks for the PR!

hanspagel merged commit 6ca7ebd into ueberdosis:main

mmachatschek deleted the replace_nodesass branch

July 15, 2021 08:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment