Move back from tsup/esbuild to rollup #3720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
splincode
reviewed
Feb 8, 2023
svenadlung
approved these changes
Feb 8, 2023
aliasliao
pushed a commit
to aliasliao/tiptap
that referenced
this pull request
May 24, 2023
* fix: bring back global rollup config * fix: add rollup build for packages except pm * fix: rollup global build * fix: fix memory leak on build * fix(character-count): revert files * fix: builds run individual per rollup and lerna * chore: remove old rollup * fix(blockquote): correct the main module path * fix(character count): bump version number
andrewlu0
pushed a commit
to trybaseplate/tiptap
that referenced
this pull request
Oct 20, 2023
* fix: bring back global rollup config * fix: add rollup build for packages except pm * fix: rollup global build * fix: fix memory leak on build * fix(character-count): revert files * fix: builds run individual per rollup and lerna * chore: remove old rollup * fix(blockquote): correct the main module path * fix(character count): bump version number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix a few issues introduced in version beta.210 to beta.213 by going back to the old build process for all packages except the
@tiptap/pmpackage.Each package now has it's own build process to avoid build memory leaks and building now is happening via lerna running through each package individually.
Issues connected to this:
@tiptap/*package versions pull in mismatched dependency versions #3692