Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updateAttributes: update current node only #5154

Merged
merged 13 commits into from
Jun 7, 2024
Merged

updateAttributes: update current node only #5154

merged 13 commits into from
Jun 7, 2024

Commits on May 15, 2024

  1. updateAttributes: update current node only 

    There is a bug (?) in updateAttributes, attributes of the node are updated
but also all it's parent nodes of the same type. This is problematic with
things like nested lists, but also nested paragraphs, etc

The fix updates attributes of the node ("last") only and leaves the
parents intact
    @silenius
    silenius committed May 15, 2024
    Configuration menu
    Copy the full SHA
    ca441ef View commit details
    Browse the repository at this point in the history

  2. fix types

    @silenius
    silenius committed May 15, 2024
    Configuration menu
    Copy the full SHA
    ff1ccbd View commit details
    Browse the repository at this point in the history

  3. s/NodeType/Node

    @silenius
    silenius committed May 15, 2024
    Configuration menu
    Copy the full SHA
    7d7e4e5 View commit details
    Browse the repository at this point in the history

  4. some more type fixes

    @silenius
    silenius committed May 15, 2024
    Configuration menu
    Copy the full SHA
    3bbc41c View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. make tsc happy

    @silenius
    silenius committed May 16, 2024
    Configuration menu
    Copy the full SHA
    90a5a7b View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Merge branch 'main' into updateAttributes

    @silenius
    silenius committed May 17, 2024
    Configuration menu
    Copy the full SHA
    8a16bbe View commit details
    Browse the repository at this point in the history

  2. Revert "Merge branch 'main' into updateAttributes" 

    This reverts commit 8a16bbe, reversing
changes made to 90a5a7b.
    @silenius
    silenius committed May 17, 2024
    Configuration menu
    Copy the full SHA
    359b309 View commit details
    Browse the repository at this point in the history

  3. make eslint happy

    @silenius
    silenius committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e7f2a26 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. lastPos: check is >= 0

    @silenius
    silenius committed May 18, 2024
    Configuration menu
    Copy the full SHA
    04d147d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'updateAttributes' of github.com:silenius/tiptap into up… 

    …dateAttributes
    @silenius
    silenius committed May 18, 2024
    Configuration menu
    Copy the full SHA
    8704dfd View commit details
    Browse the repository at this point in the history

  3. fix types

    @silenius
    silenius committed May 18, 2024
    Configuration menu
    Copy the full SHA
    31ce7af View commit details
    Browse the repository at this point in the history

  4. make tsc happy

    @silenius
    silenius committed May 18, 2024
    Configuration menu
    Copy the full SHA
    20bb099 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Reapply "Merge branch 'main' into updateAttributes" 

    This reverts commit 359b309.
    @silenius
    silenius committed May 20, 2024
    Configuration menu
    Copy the full SHA
    cc25b15 View commit details
    Browse the repository at this point in the history