Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of MaterialApp #17

Merged
merged 11 commits into from
Sep 7, 2020
Merged

Get rid of MaterialApp #17

merged 11 commits into from
Sep 7, 2020

Conversation

ueman
Copy link
Owner

@ueman ueman commented Aug 23, 2020

No description provided.

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #17 into master will decrease coverage by 2.28%.
The diff coverage is 64.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   65.80%   63.51%   -2.29%     
==========================================
  Files          11       15       +4     
  Lines         424      518      +94     
==========================================
+ Hits          279      329      +50     
- Misses        145      189      +44     
Impacted Files Coverage Δ
lib/src/feedback_functions.dart 0.00% <0.00%> (ø)
lib/src/l18n/translation.dart 30.43% <30.43%> (ø)
lib/src/theme/feedback_theme.dart 56.25% <56.25%> (ø)
lib/src/utilities/media_query_from_window.dart 61.90% <61.90%> (ø)
lib/src/feedback_controller.dart 88.88% <66.66%> (-11.12%) ⬇️
lib/src/better_feedback.dart 87.17% <85.71%> (-10.05%) ⬇️
lib/src/feedback_widget.dart 80.00% <95.23%> (+3.00%) ⬆️
lib/src/controls_column.dart 89.58% <100.00%> (+0.49%) ⬆️
lib/src/l18n/localization.dart 100.00% <100.00%> (ø)
lib/src/utilities/feedback_app.dart 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e0715...49b36f3. Read the comment docs.

@ueman ueman merged commit 49b36f3 into master Sep 7, 2020
@ueman ueman deleted the replace_material_app branch September 7, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant