gpgme_ctx_set_engine_info added as a new interface #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why don't you put that method to However, I'm surprised that |
|
@chaiwat You're right. now it has been moved into Ctx na. Yes.... so maybe initially people tried to implemented it but turned out to be it was forgotten to implement... I assume.... |
|
@ueno Please merge this branch 🙇 お願いします |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ruby-gpgme's set_info contaminates the global gpg status. For example, if there are several gpg process running simultaneously, one gpg fails since the other deprives of the working repository.
Then I added a new interface called
set_info_safe, which take context as an argument so that it does not harm the other gpg related processes.