Skip to content

Commit

Permalink
reverting changes with optional val datasets
Browse files Browse the repository at this point in the history
  • Loading branch information
jindrahelcl committed Sep 18, 2018
1 parent 93db67c commit 1baba63
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions neuralmonkey/experiment.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,13 @@ def build_model(self) -> None:
if self.train_mode:
check_dataset_and_coders(self.model.train_dataset,
self.model.runners)
if self.model.val_dataset is not None:
if isinstance(self.model.val_dataset, Dataset):
check_dataset_and_coders(self.model.val_dataset,
if isinstance(self.model.val_dataset, Dataset):
check_dataset_and_coders(self.model.val_dataset,
self.model.runners)
else:
for val_dataset in self.model.val_dataset:
check_dataset_and_coders(val_dataset,
self.model.runners)
else:
for val_dataset in self.model.val_dataset:
check_dataset_and_coders(val_dataset,
self.model.runners)

if self.train_mode and self.model.visualize_embeddings:
visualize_embeddings(self.model.visualize_embeddings,
Expand Down Expand Up @@ -340,7 +339,7 @@ def create_config(train_mode: bool = True) -> Configuration:
config.add_argument("epochs", cond=lambda x: x >= 0)
config.add_argument("trainer")
config.add_argument("train_dataset")
config.add_argument("val_dataset", required=False, default=[])
config.add_argument("val_dataset")
config.add_argument("evaluation")
config.add_argument("test_datasets", required=False, default=[])
config.add_argument("logging_period", required=False, default=20)
Expand Down

0 comments on commit 1baba63

Please sign in to comment.