Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special char escaping #98

Merged
merged 4 commits into from Nov 24, 2023
Merged

Special char escaping #98

merged 4 commits into from Nov 24, 2023

Conversation

jlgeering
Copy link
Collaborator

@jlgeering jlgeering commented Aug 23, 2022 •
edited by mruoss

Requirements

  • Entry in CHANGELOG.md was created
  • Link to documentation on https://yaml.org/ is provided in the PR description
  • Functionality is covered by newly created tests

@mruoss
Copy link
Collaborator

mruoss commented Aug 23, 2022

reminder (from the docs):

Note that escape sequences are only interpreted in double-quoted scalars. In all other scalar styles, the “\” character has no special meaning and non-printable characters are not available.

@mruoss mruoss force-pushed the escape-chars branch 2 times, most recently from 470a7e4 to 13e1279 Compare August 25, 2022 11:23
@mruoss mruoss force-pushed the escape-chars branch 2 times, most recently from 46f46d7 to 658c88c Compare November 15, 2023 21:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited

Pull Request Test Coverage Report for Build c44a016f23aa18655e7f845ccce38c32f22d30e2-PR-98

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build cd3a2772602c49f9c1646df0f71b1cb399d503f8: 0.0%
Covered Lines: 121
Relevant Lines: 121
💛 - Coveralls

@mruoss mruoss force-pushed the escape-chars branch 4 times, most recently from 3ca629e to da978da Compare November 18, 2023 14:07
@mruoss mruoss marked this pull request as ready for review November 18, 2023 14:12
@mruoss mruoss changed the title WIP char escaping Special char escaping Nov 19, 2023
mruoss
mruoss reviewed Nov 19, 2023
View reviewed changes
BENCHMARK.md Outdated
<td style="white-space: nowrap; text-align: right">43.77 ms</td>
<td style="white-space: nowrap; text-align: right">48.11 ms</td>
<td style="white-space: nowrap; text-align: right">1.58</td>
<td style="white-space: nowrap; text-align: right">632.01 ms</td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah ok. I'll address this problem in a separate PR.

@mruoss mruoss force-pushed the escape-chars branch 6 times, most recently from 536da82 to bd26604 Compare November 20, 2023 15:37
@mruoss mruoss force-pushed the escape-chars branch 3 times, most recently from 965bc9c to 662ae4a Compare November 21, 2023 21:51
@mruoss mruoss force-pushed the escape-chars branch 2 times, most recently from 15ad7f2 to 049966a Compare November 23, 2023 17:54
@mruoss mruoss merged commit 8c18aee into main Nov 24, 2023
18 checks passed
@mruoss mruoss deleted the escape-chars branch December 27, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruoss mruoss mruoss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlgeering @mruoss