Provide a way to disable asynchronous execution #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 12, 2013 15:43
This is done by returning a FakeFuture that is not the result of submitting the work to an executor but returned directly.
|
@sensej I don't know if GitHub tells you about new pull requests via mail, but this ping will certainly get through to you ;-) |
|
That's a great idea! I was often irritated myself when something went wrong. |
|
Ok, then I will merge. |
matze
added a commit
that referenced
this pull request
Aug 13, 2013
Provide a way to disable asynchronous execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's a royal pain in the butt to debug Concert because everything can potentially run asynchronously and the raised exceptions usually do not tell where they happened.
This change adds the module variable
concert.asynchronous.DISABLEwhich, when set toTrue, will create fake Future objects which are the same as real Futures except that they aren't submitted to any kind of executor but return immediately with a valid result. Hence it's much easier to reason about the flow of execution.To make good use of this feature I added a nose plugin, that is installed with the custom runner
runtests.py. Note that it takes the same options as if you'd callnosetests.