Numpy accumulate #376
Merged
Numpy accumulate #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matze if there isn't a more elegant way this is finished. |
|
No, looks like a good idea. However, you should also check the values in the test not only the type. Better safe than sorry. |
|
From my point of view, we can merge this 👍 |
tfarago
force-pushed
the
numpy-accumulate
branch
from
3249764
to
7c12d79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be very convenient to have the data accumulated already as a numpy ND stack when implementing general backprojectors or data processing routines in general. With this we can do for example
backproject.insert(accumulate.items[:, height, :])which wouldn't be so simple AFAIK with a list of 2D numpy arrays.