Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend queue #387

Merged
merged 2 commits into from
Apr 13, 2016
Merged

Extend queue #387

merged 2 commits into from
Apr 13, 2016

Conversation

tfarago
Copy link
Contributor

@tfarago tfarago commented Apr 11, 2016

With this I get a bump in download bandwidth for the dimax from ~140 MB/s to ~210 MB/s.

@tfarago
Copy link
Contributor Author

tfarago commented Apr 12, 2016

@matze just attracting your attention.

@tfarago
Copy link
Contributor Author

tfarago commented Apr 12, 2016

BTW what's up with Travis?

@matze
Copy link
Contributor

matze commented Apr 12, 2016

That's why I was reluctant to do anything, thought you would care about that issue with Gevent.

@tfarago
Copy link
Contributor Author

tfarago commented Apr 12, 2016

I lost the failure between all those warnings. I am on it now. We should fix those too.

@tfarago
Copy link
Contributor Author

tfarago commented Apr 12, 2016

Which version of gevent do I actually need to make your Greenlet subclass work? I just installed the 1.1.1 version (just what pip gave me) and I get an error when the subclass tries to assign kwargs.

from gevent.event import Event
else:
from threading import Event

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Event seriously not patched with gevent.monkey.patch_all()??

@tfarago
Copy link
Contributor Author

tfarago commented Apr 12, 2016

OK, should be fixed by the last ugly commit.

@matze
Copy link
Contributor

matze commented Apr 12, 2016

Urgs, but okay 👍

enable waiting for processing all elements and blocking.
@tfarago tfarago merged commit 2535efc into master Apr 13, 2016
@tfarago tfarago deleted the extend-queue branch April 13, 2016 12:20
@matze matze removed the ready label Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants