[production/RRFS.v1] Add clear-sky shortwave downward at surface flux to available diagnostics. #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinswales
requested review from
grantfirl,
Qingfu-Liu and
mzhangw
as code owners
10 tasks
Qingfu-Liu
approved these changes
Apr 24, 2024
|
This PR#198 is the same as PR#197 |
grantfirl
reviewed
Apr 25, 2024
| ! sfcnirbmu,sfcnirdfu,sfcvisbmu,sfcvisdfu, ! | ||
| ! sfcnirbmd,sfcnirdfd,sfcvisbmd,sfcvisdfd, ! | ||
| ! im, levs, deltim, fhswr, ! | ||
| ! dry, icy, wet ! | ||
| ! input/output: ! | ||
| ! dtdt,dtdtnp, ! | ||
| ! outputs: ! | ||
| ! adjsfcdsw,adjsfcnsw,adjsfcdlw,adjsfculw, ! | ||
| ! adjsfcdsw,adjsfcdswc,adjsfcnsw,adjsfcdlw, ! |
There was a problem hiding this comment.
It doesn't matter much since this is just in comments, but adjsfculw is still being output in the arguments below.
grantfirl
approved these changes
Apr 25, 2024
MatthewPyle-NOAA
changed the title
|
Tests are done at ufs-community/ufs-weather-model#2249. @grantfirl @dustinswales can you merge in this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new diagnostic, instantaneous downward shortwave flux at the surface assuming clear-sky conditions.
This is needed for RRFSv1.
Analogous to #197 into ufs/dev