Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[production/RRFS.v1] Add clear-sky shortwave downward at surface flux to available diagnostics. #2249

Conversation

dustinswales
Copy link
Collaborator

@dustinswales dustinswales commented Apr 23, 2024

Description:

This PR adds a new diagnostic, instantaneous downward shortwave flux at the surface assuming clear-sky conditions.
This is needed for RRFSv1.

Analogous to #2248 into develop.

Commit Message:

N/A

Priority:

High: Time-sensitive project. Needed for RRFSv1.

Git Tracking

UFSWM:

N/A

Sub component Pull Requests:


Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • None.

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@dustinswales dustinswales changed the title Add SW clear-sky downward flux at surface to available diagnostics Add clear-sky shortwave downward at surface flux to available diagnostics. Apr 23, 2024
@MatthewPyle-NOAA MatthewPyle-NOAA changed the title Add clear-sky shortwave downward at surface flux to available diagnostics. [production/RRFS.v1] Add clear-sky shortwave downward at surface flux to available diagnostics. May 1, 2024
@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 3, 2024

@dustinswales can you sync up branches? We will go ahead for testing.

@dustinswales
Copy link
Collaborator Author

@jkbk2004 Sorry, I was out Friday. All synced up now.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 7, 2024

@MatthewPyle-NOAA This pr ran ok on hera and hercules. We can move on merging after the test on wcoss2.

@MatthewPyle-NOAA
Copy link
Collaborator

@jkbk2004 Good to merge from my perspective.

Copy link
Collaborator

@MatthewPyle-NOAA MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving....

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit 6431581 into ufs-community:production/RRFS.v1 May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants