z0t bug fixes #23
z0t bug fixes #23
Conversation
sync with ufs-community branch
HelinWei-NOAA
requested review from
grantfirl and
ChunxiZhang-NOAA
as code owners
|
@HelinWei-NOAA You you have a PPT file to show how those bug fixes improve the forecasts, please attach it in the description section for this PR. |
|
@HelinWei-NOAA Please create a corresponding fv3atm PR and ufs-weather-model PR, respectively. |
|
@ChunxiZhang-NOAA We don't have any modification for those two repositories. I can create those PRs if you want to commit our ccpp-physics changes separately.
|
|
done
|
@HelinWei-NOAA Those two upstream PRs are needed even though no code changes in fv3atm and ufs-weather-model. I can create those two PRs for you. |
|
@ChunxiZhang-NOAA I though you would combine our bug fixes with other physics upgrades. Thanks for creating those two PRs for us.
|
|
@HelinWei-NOAA Could you make your baseline.hr1 branch update-to-date with following method: assuming you have remote set to origin: https://github.com/HelinWei-NOAA/ccpp-physics and upstream: https://github.com/ufs-community/ccpp-physics; and you are in your baseline.hr1 branch. You can try: git fetch upstream, then git merge upstream/ufs/dev |
|
Done. Thanks for the instruction. |
|
@HelinWei-NOAA My pleasure. The ufs-weather-model PR#1493 and fv3atm PR#610 were created. |
|
@HelinWei-NOAA Could you merge your baseline.hr1 branch with the official repository to make it up-to-date once more? A few new commits have been merged into ufs/dev branch since your last update. Thanks. |
|
Done.
|
@HelinWei-NOAA Thank you! |
|
All tests are done on ufs-community/ufs-weather-model#1493 side. Can we start merging in this pr? |
|
@jkbk2004 Done. |
To fix two bugs related to the thermal roughness raised in issues 963 and 964.
The presentation
shows the impact of the bug mentioned in NCAR#964
Another presentation
addresses the impact of both bugs.