Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add low resolution tests #194

Merged
merged 428 commits into from
Oct 22, 2020

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Sep 23, 2020

Description of changes

  • Adds tests to replicate existing c96-1/4 deg tests (decomp, threads etc) at c96-1deg for the coupled model.

  • Changes default to be a 1d run. Replaces 2d/3d/restart test with a 12h/1d/restart test. Restart test is currently implemented at c96mx025 resolution.

  • Changes mediator restart directory to RESTART. Mediator restart case_name is changed from "ufs.s2s" to "ufs.cpld"

  • Updates MOM6 and FV3 to match current ufs-weather

Specific notes

Issues Fixed (include github issue #):

ufs-weather Issue #222
Issue #83
Dependent PR #204

Are changes expected to change answers?

Specific changes:

  • cold nems.configure files are removed
  • cpld_control_c192 (c192mx050), cpld_ca (c96mx100 Cellular Automata) are added in addition to c96/mx100 version of existing tests.
  • All tests run with either fv3_conf/cpld_control_run.IN or fv3_conf/cpld_bmark_run.IN

Testing performed:

  • machines: hera,orion,dell-p3
  • details:

Hashes used for testing:

  • NEMS: f102e36
  • CMEPS: 4d50adf
  • FV3: b955f81
  • MOM6: 7a76a13
  • CICE: ac617cd
  • WW3: 9c22b13
  • FMS:f61416f
  • stochastic_physics: 6eac84

Co-authored by:

DeniseWorthen and others added 30 commits July 7, 2020 16:30
make all compile statements CICE6
* move submodules around

Change-Id: Ibdb7216abe1e50df41fce0826f450cbdcfe101ef

* cmake required changes

Change-Id: I54ccc0dc678b195ea9a5d18dfad12e2ed3c179fe

* forgot the NetCDF finder

Change-Id: Ide433b5a16c180b7576e73f08484dfc01430399f

* update the list of files in MOM6 following latest merge

Change-Id: Ib7d5d5f6f3fbc18d026b8400de371a8001de69d8
for setting coupling_mode using CMEPS mediator to either nems_orig
or nems_frac
add frac_grid default to nml, fix compile for cice6, fix file
name in one of the tests
add MOM input template for waves at 1/2 deg
add CHECKSUM=false setting to all mom templates
@DeniseWorthen DeniseWorthen marked this pull request as ready for review October 21, 2020 11:21
@DeniseWorthen
Copy link
Collaborator Author

This will also update NEMS to f102e36. This should be OK since that the NEMS commit states it should happen after weather PR 213 which has been closed.

make do_ca,ca_sbs and ca_global as variables in input.mom6_ccpp.nml.IN
white space in rt.conf
@DeniseWorthen
Copy link
Collaborator Author

I will regenerate the CA baseline test.

I also have a fix for the FV3_RESTART_H issue and have already tested it. I will merge that fix and then re-run all the baselines.

@junwang-noaa
Copy link
Collaborator

Denise, thanks for making the code changes.

@DeniseWorthen
Copy link
Collaborator Author

DeniseWorthen commented Oct 22, 2020

All RTs have been re-run. My commit message on the last one mistakenly said 'orion logs'. It is the p3 logs.

Copy link
Collaborator

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot work in the two PRs (194 and 204). Thanks for the nice work!

Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding the cpld CA case and in general just making everything cleaner.

@DeniseWorthen DeniseWorthen merged commit bf485c2 into ufs-community:develop Oct 22, 2020
Regression Test package automation moved this from In progress to Done Oct 22, 2020
DeniseWorthen added a commit to ufs-community/ufs-weather-model that referenced this pull request Oct 26, 2020
Replaces current coupled tests, default vars and other files to implement low resolution tests from ufs-s2s-model in the unified repository.

See ufs-s2s-model PR # 204 (ufs-community/ufs-s2s-model#204) and PR # 194 (ufs-community/ufs-s2s-model#194) for more detail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline change PR will change answers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants