Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default resolution #204

Merged
merged 122 commits into from
Oct 21, 2020

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Sep 30, 2020

Description of changes

  • Cleans up default_vars to reflect new default test resolution of c96-1deg ocean and ice.

  • Reproduces existing tests by adding non-default configurations (eg c96-1/4deg ocean and ice) explicitly

  • Removes many old settings in existing tests which are now defaults (eg. setting input_nml to the ccpp version).

  • Adds s2s tests to replicate existing c384-1/4 deg tests for the control, benchmark, benchmark+waves and c384mx025 frac grid configurations. Also replicates c96mx025 restart test. These tests are b4b with existing baselines.

Three MOM6 default settings have changed to match MOM6 defaults for the 1deg model.

  • MOM6 1deg does not have a river runoff file so MOM6_RIVER_RUNOFF is now set False

  • MOM6_REPRO_LA and MOM6_THERMO_SPAN are now False (the default MOM6 setting). The non-default use of MOM6_THERMO_SPAN are removed since testing showed that using the default setting was b4b.

  • A new MOM6 setting MOM6_USE_WAVES (default False) has been added in order to combine the wave and non-wave MOM input templates

Specific notes

Issues Fixed (include github issue #):

ufs-weather issue #221
ufs-s2s issue #218
Follow-on ufs-s2s PR #194

Are changes expected to change answers?

  • No answer changes. Added tests repro existing tests

Specific changes:

  • wave specific MOM input template is removed, cold nems.configure files are removed
  • in addition to above added tests, the 1stepcold test and the (unused) bmark restart test is removed
  • removes conversion from hours-> secs for CICE dumpfreq in edit_inputs since in CICE6 the restart dump frequency can no longer be set as "s".

Testing performed:

  • machines: hera, orion, dell-p3
  • added s2s tests are currently compared to the matching "cpld_" test.
  • 35d RTs were tested by running both wave and non-wave for 1 date for the develop branch and for this branch with both the "cpld" version and the "s2s" versions. Baselines are not retained for these tests, but spot checking of the forecast files after 2 days showed all tests (develop and the two tests in the branch) reproduced each other.

Hashes used for testing:

  • NEMS: f102e36
  • CMEPS: 4d50adf
  • FV3: 90bc1a4
  • MOM6: 3ce81f4
  • CICE: ac617cd
  • WW3: 9c22b13
  • FMS: f61416f
  • stochastic_physics: 6eac84

Co-authored by:

DeniseWorthen and others added 30 commits November 20, 2019 12:22
merge develop/ufs-s2s-model
MOM_input template for initial condition files
Add debug compilation flag specification at top level (#17)
update to current ufs-weather-app (#19)
Remove IPD tests and CCPP repro tests from the regression test system…
the mediator restart name will be changed in a later commit
@DeniseWorthen DeniseWorthen marked this pull request as ready for review October 19, 2020 13:12
@DeniseWorthen
Copy link
Collaborator Author

This PR is ready for final RT testing and commit. My understanding is that it will follow on PR #213.

@junwang-noaa junwang-noaa mentioned this pull request Oct 20, 2020
@DeniseWorthen
Copy link
Collaborator Author

Tests are running on Orion, Dell-p3 and Hera.

@DeniseWorthen
Copy link
Collaborator Author

I need to re-run the RTs. I had mistakenly left three of the exisiting tests commented out (2threads, decomp and satmedmf).

@DeniseWorthen
Copy link
Collaborator Author

Ready for review.

Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of changes, but they all look good to me. Thanks for all of this @DeniseWorthen I know this was no small task but we'll all appreciate the end result!

@DeniseWorthen DeniseWorthen merged commit 953ef14 into ufs-community:develop Oct 21, 2020
Regression Test package automation moved this from In progress to Done Oct 21, 2020
@SMoorthi-emc
Copy link
Collaborator

SMoorthi-emc commented Oct 21, 2020 via email

@DeniseWorthen
Copy link
Collaborator Author

Thanks Moorthi. I was mistaken in my first statement about what stop_n does. It only controls the timers in CICE so it should work with pretty much any setting (other than 0 probably).

DeniseWorthen added a commit to ufs-community/ufs-weather-model that referenced this pull request Oct 26, 2020
Replaces current coupled tests, default vars and other files to implement low resolution tests from ufs-s2s-model in the unified repository.

See ufs-s2s-model PR # 204 (ufs-community/ufs-s2s-model#204) and PR # 194 (ufs-community/ufs-s2s-model#194) for more detail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change PR should not change answers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants