Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster compile and HAFS app to be compiled with 64bit #1578

Merged
merged 27 commits into from
Mar 7, 2023

Conversation

SadeghTabas-NOAA
Copy link
Collaborator

@SadeghTabas-NOAA SadeghTabas-NOAA commented Jan 23, 2023

…MAQ in rt.conf

Description

This PR contains changes to rt.conf for FASTER compile UFS regression tests.
Changes to rt.conf:

  • FASTER compile option turned on for ATM, S2SWA, NG-GODAS, ATML and ATMAQ

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

PR #1610

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@junwang-noaa
Copy link
Collaborator

@SadeghTabas-NOAA Code change looks good to me. Please run RT to check the run time change and if there are any failed test. Thanks

@SadeghTabas-NOAA SadeghTabas-NOAA added the enhancement New feature or request label Jan 23, 2023
@github-actions
Copy link

@SadeghTabas-NOAA please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date
  • cice NOT up to date

@SadeghTabas-NOAA
Copy link
Collaborator Author

SadeghTabas-NOAA commented Jan 31, 2023

hera.intel job completed. RT passed, however the runtime increased significantly.

@SadeghTabas-NOAA
Copy link
Collaborator Author

It looks like, the FASTER compile option makes the runs significantly slower than before. Please find the full RT results for Orion and Hera in the following directory:
Orion: /work/noaa/nems/stabas/git/PR1578/
Hera: /scratch1/NCEPDEV/nems/Sadegh.Tabas/git/SadeghTabas-NOAA/PR1578_20230130

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Feb 1, 2023

@SadeghTabas-NOAA I was wondering if it slows down across all cases? then, we may need more time for the pr.

@SadeghTabas-NOAA
Copy link
Collaborator Author

@jkbk2004 I'm doing the RT test for jet and gaea as well, I'll let you know once its done, I'll upload the logs here.

@SadeghTabas-NOAA
Copy link
Collaborator Author

RT job on jet completed, the FASTER compile option makes the runs significantly slower than before. Please find the full RT results for jet in the following directory:
jet: /lfs4/HFIP/h-nems/Sadegh.Tabas/git/SadeghTabas-NOAA/PR1578/

@BrianCurtis-NOAA
Copy link
Collaborator

Seems that the verdict is we should not use the FASTER option at all?

@SadeghTabas-NOAA
Copy link
Collaborator Author

@BrianCurtis-NOAA I guess the current version of Faster Compile makes the process much slower and it needs modification or not using it at all.

@SadeghTabas-NOAA
Copy link
Collaborator Author

I made a google sheet for the Faster Compile option results. It seems Faster Compile made the Compiles process slower, however it increased the speed for the Tests.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 3, 2023

@SadeghTabas-NOAA #1604 was merged. can you sync up? mainly log files. it might be easier way to save your log files and attach in the PR after sync up.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 3, 2023

@SadeghTabas-NOAA mom6/fv3 restart file format was updated. you can take a look: https://github.com/SadeghTabas-NOAA/ufs-weather-model/blob/FASTER_Compile_Test/tests/tests/control_p8 Another thing to check is this pr adds 4 *_faster test cases and no impact on all other cases. Then, we might combine with #1610. We need to point to @DusanJovic-NOAA hafs_64bit_fms fv3 branch. Sorry I am flipping my mind about combing PRs. If you agree, we can save time in that way.

@jkbk2004 jkbk2004 requested a review from zach1221 March 3, 2023 15:26
on-behalf-of @ufs-community <jong.kim@noaa.gov>
on-behalf-of @ufs-community <jong.kim@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 4, 2023

Automated RT Failure Notification
Machine: gaea
Compiler: intel
Job: RT
[RT] Repo location: /lustre/f2/pdata/ncep/emc.nemspara/autort/pr/1213491813/20230304203007/ufs-weather-model
[RT] Error: Test cpld_control_p8_faster 021 failed in check_result failed
[RT] Error: Test cpld_control_p8_faster 021 failed in run_test failed
Please make changes and add the following label back: gaea-intel-RT

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 6, 2023

Cheyenne and Gaea sporadically unstable. re-submission of jobs worked out ok for failed cases.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 6, 2023

@BrianCurtis-NOAA @SadeghTabas-NOAA once tests are confirmed on wcoss2, this pr is ready for merging.

@DeniseWorthen
Copy link
Collaborator

@SadeghTabas-NOAA Could you please edit the title so that we can easily see in the commit list that this also committed the change for HAFs in 64 Bit mode?

@SadeghTabas-NOAA SadeghTabas-NOAA changed the title Faster compile option turned on in rt.conf Faster compile and HAFS app to be compiled with 64bit Mar 6, 2023
@SadeghTabas-NOAA
Copy link
Collaborator Author

@BrianCurtis-NOAA Thanks,
@DeniseWorthen I modified the title, thanks.

@BrianCurtis-NOAA
Copy link
Collaborator

@jkbk2004 @SadeghTabas-NOAA All WCOSS2 related testing is completed. Apologies for the delay.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 7, 2023

@SadeghTabas-NOAA fv3 pr was merged. Can you update submodule pointer and revert change in gitmodules?

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 7, 2023

@SadeghTabas-NOAA can you make sure about fv3 hash? correct one is NOAA-EMC/fv3atm@8418428

@jkbk2004 jkbk2004 merged commit b388eb9 into ufs-community:develop Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. enhancement New feature or request jenkins-ci Jenkins CI: ORT build/test on docker container Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test the FASTER compile option in UFS applications
8 participants