Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies to CCPP metadata #180

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Aug 4, 2020

Description

This PR adds the capability to specify dependencies for CCPP modules/DDTs/schemes in the scheme metadata. This allows us to remove the DDT/scheme dependency information from the CCPP prebuild config in fv3atm and only compile the dependencies and schemes that are used by the selected suite definition files. Until now, all schemes and scheme dependencies are compiled, regardless whether they are in use in any of the selected suites.

Changes in this PR:

  • update .gitmodules and submodule pointer for fv3atm for code review and testing
  • add compiler flags for gfortran-10
  • don't run csawmg tests on Cheyenne, both crash with a "bus error"

Note: preliminary documentation for these changes is available here: https://docs.google.com/document/d/1jmGxtLk-wuU-fokEDiR_ftHxBk5mDEGvelbKTqg-8m4/edit?usp=sharing - this will be sent out to developers once the code is merged.

Issue(s) addressed

NCAR/ccpp-framework#308

Testing

Regression tests passed against existing baseline on the following systems:

  • wcoss_cray
  • wcoss_dell_p3
  • orion.intel
  • cheyenne.gnu
  • cheyenne.intel
  • hera.intel; note: due to file system issues on hera, I had to rerun one of the tests several times (fv3_ccpp_wrtGauss_nemsio_c768) and manually update tests/RegressionTests_hera.intel.log for test 18. I noted this in tests/RegressionTests_hera.intel.log (look for DH* and *DH)

Ready to merge!

Also ran GFSv15p2 and GFSv16beta tests on macOS with clang+gfortran, including using the updated GFS_debug.F90 from CCPP.

Dependencies

Waiting on:

earth-system-radiation/rte-rrtmgp#85
NCAR/ccpp-framework#317
NCAR/ccpp-physics#483
NOAA-EMC/fv3atm#153

@climbfuji climbfuji marked this pull request as ready for review August 12, 2020 20:38
@DusanJovic-NOAA DusanJovic-NOAA merged commit 3fb6556 into ufs-community:develop Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants