Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run time information and update fv3 to use unified missing value #1823

Merged
merged 31 commits into from
Sep 7, 2023

Conversation

junwang-noaa
Copy link
Collaborator

@junwang-noaa junwang-noaa commented Jul 6, 2023

Description

This PR will add run time information in FV3ATM, CICE6 and MOM6 component and update fv3atm to use unified missing value

Input data additions/changes

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests: All the RT tests with atmf history output files will change results.

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Library Updates/Changes

  • Not Needed
  • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
  • Add issue link from JCSDA/spack-stack following this item

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved in section below
  • Confirm reviews completed in ALL sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne AND attach log to a PR comment.
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Dependent PRs:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@junwang-noaa
Copy link
Collaborator Author

The full RT passed on hera, the log file is at:

/scratch1/NCEPDEV/nems/Jun.Wang/nems/vlab/20230705/ufs-weather-model/tests/logs/RegressionTests_gaea.log_20230828

@BrianCurtis-NOAA
Copy link
Collaborator

The full RT passed on hera, the log file is at:

/scratch1/NCEPDEV/nems/Jun.Wang/nems/vlab/20230705/ufs-weather-model/tests/logs/RegressionTests_gaea.log_20230828

Did you mean to link to the Gaea log?

@junwang-noaa
Copy link
Collaborator Author

Good catch! I copied the wrong log file to this temporary file, now I lost my hera log file. I will run full RT again..

@junwang-noaa
Copy link
Collaborator Author

The hera RT log file is at:
/scratch1/NCEPDEV/nems/Jun.Wang/nems/vlab/20230705/ufs-weather-model/tests/logs/RegressionTests_hera.log_20230830

@BrianCurtis-NOAA
Copy link
Collaborator

@jkbk2004 who is assigned to this PR?

@FernandoAndrade-NOAA
Copy link
Collaborator

It looks like Acorn will be skipped for this PR, @junwang-noaa please go ahead and resolve/mark resolved conversations in the sub PRs as well as in this PR.

@junwang-noaa
Copy link
Collaborator Author

@FernandoAndrade-NOAA Done

@DeniseWorthen
Copy link
Collaborator

@FernandoAndrade-NOAA Are we ready for subcomponent PR merges?

@FernandoAndrade-NOAA
Copy link
Collaborator

@DeniseWorthen yes everything looks good to go, please continue with the merge process

@DeniseWorthen
Copy link
Collaborator

CICE is ready, hash is 2ed3c05

@jiandewang
Copy link
Collaborator

MOM6 merged, hash # is be40a4136

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Sep 7, 2023

FV3 merged as well, new hash NOAA-EMC/fv3atm@a9fa26e

@junwang-noaa
Copy link
Collaborator Author

I will update my UWM branch

@junwang-noaa
Copy link
Collaborator Author

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins-ci Jenkins CI: ORT build/test on docker container No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
7 participants