RRTMG cloud overlap method update #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 11, 2020
…r-model into iacono_cloud_overlap_merged_with_rrtmgp_and_updated
…GNU doesn't complain about non-existent input directories
…-noaa/ufs-weather-model into iacono_cloud_overlap_merged_with_rrtmgp_and_updated
climbfuji
requested review from
MinsukJi-NOAA,
DusanJovic-NOAA and
junwang-noaa
and removed request for
MinsukJi-NOAA
…gnu, cheyenne.intel
…p_rrfs_v1beta and tests/tests/fv3_ccpp_rrfs_v1beta_debug
…s/fv3_conf/ccpp*.IN
…n all regression test scripts
|
@DusanJovic-NOAA @junwang-noaa Are you able to create new baselines on wcoss and run the tests? Or is wcoss still under maintenance? |
| @@ -56,5 +56,3 @@ cp @[RTPWD]/WW3_input_data/mod_def.* . | |||
| cp @[RTPWD]/WW3_input_data/@[SYEAR]@[SMONTH]@[SDAY]/ww3_multi.inp . | |||
| cp @[RTPWD]/WW3_input_data/@[SYEAR]@[SMONTH]@[SDAY]/rmp_src* . | |||
| fi | |||
|
|
|||
| cp ${PATHRT}/../FV3/ccpp/suites/suite_${CCPP_SUITE}.xml suite_${CCPP_SUITE}.xml | |||
There was a problem hiding this comment.
So do we not need the ccpp suite file in the run directory?
There was a problem hiding this comment.
Not needed, correct.
| @@ -92,12 +92,12 @@ case $(hostname -f) in | |||
| login4.stampede2.tacc.utexas.edu) MACHINE_ID=stampede ;; ### stampede4 | |||
| esac | |||
|
|
|||
| # Overwrite auto-detect with NEMS_MACHINE if set | |||
| MACHINE_ID=${NEMS_MACHINE:-${MACHINE_ID}} | |||
There was a problem hiding this comment.
Do we know why NEMS_MACHINE does not work?
There was a problem hiding this comment.
We renamed NEMS_COMPILER to RT_COMPILER because it's got nothing to do with NEMS (anymore). Same for machine. Thus, we try to be consistent and call it RT_MACHINE.
DusanJovic-NOAA
approved these changes
Sep 28, 2020
junwang-noaa
approved these changes
Sep 28, 2020
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Point to CRH branch. * Adding rocoto where it wasn't present. * Change Externals.cfg back to default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
.gitmodulesand the submodule pointer for fv3atm for code review and testing of the following changes in fv3atm and ccpp-physics:compile.shscript and replaces it with the new cmakecompile_cmake.shscript (which is renamed tocompile.sh)NEMS_COMPILERthroughout instead of a mixture ofNEMS_COMPILERandCOMPILER(note:NEMS_COMPILERshould be renamed to something likeUFS_COMPILERorRT_COMPILERin the future, along with corresponding changes forNEMS_MACHINEetc.)readlinkcommand in the top-levelbuild.shand intests/compile.shfor macOS (similar to what was done for branch release/public-v1cp ${PATHRT}/../FV3/ccpp/suites/suite_${CCPP_SUITE}.xml suite_${CCPP_SUITE}.xmlfromtests/fv3_conf/ccpp*.IN, i.e. no longer copy suite definition files to regression test run directoriestests/tests/fv3_ccpp_rrfs_v1betaandtests/tests/fv3_ccpp_rrfs_v1beta_debug(cherry-picked from PR release/public-v2: remove WW3, update modulefiles and cmake configs, update .gitmodules #205 for branch release/public-v2)Testing
Before updating tests
tests/tests/fv3_ccpp_rrfs_v1betaandtests/tests/fv3_ccpp_rrfs_v1beta_debug, the regression tests passed against existing baseline on:Logs updated in the PR (didn't test on wcoss, because I have no access and because wcoss is in maintenance).
Updating tests
tests/tests/fv3_ccpp_rrfs_v1betaandtests/tests/fv3_ccpp_rrfs_v1beta_debugrequires new baselines, new baseline tag is 20200923.New baselines were created on the following machines and regression tests passed (logs updated in the PR):
STILL RUNNING: wcoss_cray
Note. A small change to
compile.shwas necessary for wcoss_cray after all other regression tests were done (84a036c). We reran the regression tests on hera.intel and wcoss_dell_p3 to make sure that this change also works on the other platforms.Dependencies
NCAR/ccpp-physics#487
NOAA-EMC/fv3atm#157
#184
Not a dependency, but for the corresponding ufs-s2s-model PR, see ufs-community/ufs-s2s-model#193.