Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esmf810 #188

Merged
merged 22 commits into from
Aug 25, 2020
Merged

Esmf810 #188

merged 22 commits into from
Aug 25, 2020

Conversation

junwang-noaa
Copy link
Collaborator

@junwang-noaa junwang-noaa commented Aug 20, 2020

Description

-Add GFSv16 performance tuning to fv3 develop branch.
-rt_orion.conf is merged into rt.conf, and orion baseline is moved to emc.nemspara account.
The baseline results will change because the isrctermprocessing is changed from 1 to 0, this will allow a more balanced regridding between fcst grid and write grid.

Issue(s) addressed

ufs-community/ufs-weather-model#142

Testing

How were these changes tested?
The RT test has been run on dell, cray, orion, is now running on cray.

What compilers / HPCs was it tested with?
Intel compiler.
Are the changes covered by regression tests?
Yes.

Dependencies

fv3atm PR #160
nems PR #76

These two PRs need to be committed first.

@climbfuji
Copy link
Collaborator

@junwang-noaa I am going through my 777 (!) emails while I was on leave, then look at this PR first thing.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, I am compiling the software stack for hera.gnu and will run the tests (including the parallel tests) afterwards.

@@ -355,11 +355,6 @@ SINGLE_NAME=''

TESTS_FILE='rt.conf'

if [[ $MACHINE_ID = orion.* ]]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do the same with Cheyenne and Stampede in the future?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, but I think we may need an option to define which tests we will not run on a certain platforms.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I remember we talked about this. Something like a -cheyenne.intel, i.e. the - negates running the test on that platform. Same for COMPILE and RUN lines. Not that for compile steps that work on all platforms, you can just use one COMPILE line and leave the machine column empty.

@junwang-noaa junwang-noaa merged commit 2e0dc94 into ufs-community:develop Aug 25, 2020
@junwang-noaa junwang-noaa deleted the esmf810 branch October 30, 2020 14:39
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model.p7b that referenced this pull request Jul 20, 2021
HWRF physics implementation in CCPP
- addition of new CCPP schemes to ccpp_prebuild_config.py
- update of suite definition files related to HWRF physics
- update of GFS_typdefs.{F90,meta} with new/modified variables for HWRF physics
- additional logic in FV3GFS_io.F90 for HWRF Noah LSM

Co-authored-by: Jun.Wang <Jun.Wang@noaa.gov>
Co-authored-by: Jili Dong <Jili.Dong@noaa.gov>
Co-authored-by: Bin Liu <Bin.Liu@noaa.gov>
Co-authored-by: Chunxi.Zhang-NOAA <Chunxi.Zhang@noaa.gov>
Co-authored-by: andrew.hazelton <andrew.hazelton@noaa.gov>
Co-authored-by: Jili.Dong@noaa.gov <Jili.Dong@v72a1.ncep.noaa.gov>
Co-authored-by: ZhanZhang-NOAA <zhan.zhang@noaa.gov>
Co-authored-by: Grant Firl <grantf@ucar.edu>
Co-authored-by: Man.Zhang <Man.Zhang@noaa.gov>
Co-authored-by: Dom Heinzeller <dom.heinzeller@noaa.gov>
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants