Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for cloud autort and blstores #1887

Merged
merged 48 commits into from
Sep 18, 2023
Merged

Updates for cloud autort and blstores #1887

merged 48 commits into from
Sep 18, 2023

Conversation

zach1221
Copy link
Collaborator

@zach1221 zach1221 commented Sep 7, 2023

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
    • LOG:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

Adding new blstore directories to bl.py and rt.sh so code management to transfer new baselines as needed. Adding separate noaacloud jenkins file. Updating jenkins-ci pipeline jenkins file to include sonarqube. Added noaacloud machine name to rt.conf to stipulate which tests should be run on the cloud platforms.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

Blocking Dependencies

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@zach1221 zach1221 changed the title Update regression test scripts rt.sh, rt.conf add jenkinsfile Updates for cloud autort and blstores Sep 7, 2023
@zach1221 zach1221 added noaacloud-aws-RT Run regression tests in NOAAcloud (AWS) noaacloud-gcp-RT Create new baselines and run regression tests in NOAAcloud (Google Cloud) and removed noaacloud-gcp-RT Create new baselines and run regression tests in NOAAcloud (Google Cloud) labels Sep 7, 2023
@zach1221 zach1221 added the jenkins-ci Jenkins CI: ORT build/test on docker container label Sep 11, 2023
@DeniseWorthen
Copy link
Collaborator

@zach1221 What criteria was used for deciding which tests would be enabled on noaacloud? You have for example 4 HAFS ATM tests and no CDEPS DATM tests. There are no global coupled tests except for the PDLIB (unstructure waves). How were these tests decided?

@zach1221 zach1221 added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. No Baseline Change No Baseline Change and removed Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Sep 15, 2023
@zach1221 zach1221 added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ci Jenkins CI: ORT build/test on docker container labels Sep 15, 2023
@BrianCurtis-NOAA
Copy link
Collaborator

BrianCurtis-NOAA commented Sep 15, 2023

wcoss2:

Found Python: /usr/bin/python3.6
Calling CCPP code generator (ccpp_prebuild.py) for suites --suites=FV3_HAFS_v1_.gfdlmp_tedmf_nonsst ...
CMake Error at FV3/ccpp/CMakeLists.txt:40 (message):
  An error occured while running ccpp_prebuild.py, check
  /lfs/h2/emc/ptmp/brian.curtis/FV3_RT/rt_85932/compile_hafsw_faster_intel/build_fv3_hafsw_faster_intel/F
V3/ccpp/ccpp_prebuild.{out,err}

location: /lfs/h2/emc/ptmp/brian.curtis/FV3_RT/rt_85932/compile_hafsw_faster_intel

@zach1221
Copy link
Collaborator Author

wcoss2:

Found Python: /usr/bin/python3.6
Calling CCPP code generator (ccpp_prebuild.py) for suites --suites=FV3_HAFS_v1_.gfdlmp_tedmf_nonsst ...
CMake Error at FV3/ccpp/CMakeLists.txt:40 (message):
  An error occured while running ccpp_prebuild.py, check
  /lfs/h2/emc/ptmp/brian.curtis/FV3_RT/rt_85932/compile_hafsw_faster_intel/build_fv3_hafsw_faster_intel/F
V3/ccpp/ccpp_prebuild.{out,err}

location: /lfs/h2/emc/ptmp/brian.curtis/FV3_RT/rt_85932/compile_hafsw_faster_intel

Do you think a change in my PR caused this? I haven't starting the RTs yet as jenkins-ci is still running, but I'll let you know if I have issues with this build.

tests/rt.conf Outdated Show resolved Hide resolved
@FernandoAndrade-NOAA
Copy link
Collaborator

ufs-weather-model » ort-docker-pipeline » PR-1887#1 Console [Jenkins].txt
Jenkins ci log attached, ORTs passed.

@zach1221
Copy link
Collaborator Author

@jkbk2004 @FernandoAndrade-NOAA I appears the Cheyenne account I've been using to run tests is now overspent and the queue disabled. So I think we'll be forced to skip Cheyenne.

@jkbk2004
Copy link
Collaborator

I agree we need to move to Derecho.

@jkbk2004
Copy link
Collaborator

@zach1221 resolve the conversations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins-ci Jenkins CI: ORT build/test on docker container No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants