Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pbl tapering #1910

Merged
merged 14 commits into from
Sep 28, 2023
Merged

Conversation

pjpegion
Copy link
Collaborator

@pjpegion pjpegion commented Sep 18, 2023

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
    • LOG:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

This PR adds additional tapering of the SPPT perturbations in the lower levels of the atmospheric model

From the included #1904 which closes #1898:
Add possibility to run the CA on a single tile by adding a cubed-sphere, single face tile with no contact surfaces in the CA domain specification.
Ensure decomposition of domain is proportional between the atmosphere domain and the higher resolution CA domain.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Closes: #1908

Subcomponent Pull Requests

Blocking Dependencies

None

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@pjpegion
Copy link
Collaborator Author

pjpegion commented Sep 18, 2023

@jkbk2004 This PR is for a few lines of code in the stochastic physics repo and is a very minor change. I ran the full suite of regression tests on hera, and they all pass. Can this get added to an existing regression test in the queue since EMC needs this for the next ensemble protoype?

@JongilHan66
Copy link
Collaborator

@jkbk2004 This PR is for a few lines of code in the stochastic physics repo and is a very minor change. I ran the full suite of regression tests on hera, and they all pass. Can this get added to an existing regression test in the queue since EMC needs this for the next ensemble protoype?

I have no idea on the next ensemble prototype. Could you contact Bing Fu who is now a GEFS leader?

@bingfu-NOAA
Copy link

@JongilHan66 Hi Jongil, we will start running EP5 experiment on Oct 1. The EP5 tag will be created based on the model including this PR, please help to merge it at the earliest convenience.

@pjpegion
Copy link
Collaborator Author

@JongilHan66 I meant to tag Jong Kim, not you.

@bingfu-NOAA
Copy link

Then I think the comments should go to Jong Kim @jkbk2004
we will start running EP5 experiment on Oct 1. The EP5 tag will be created based on the model including this PR, please help to merge it at the earliest convenience.

@pjpegion
Copy link
Collaborator Author

PR #1904 has been merged with this PR.

@jkbk2004
Copy link
Collaborator

@pjpegion Can you go ahead to sync up? No baseline change, so we can let tests move on.

@pjpegion
Copy link
Collaborator Author

done

@FernandoAndrade-NOAA
Copy link
Collaborator

It looks like the sub component PR dependency was already merged into its authoritative branch. @pjpegion could you revert .gtimodules and update the hash for stochastic physics?

@FernandoAndrade-NOAA FernandoAndrade-NOAA added the No Baseline Change No Baseline Change label Sep 27, 2023
@lisa-bengtsson
Copy link
Contributor

@pjpegion can you update the description of this PR since it merged in #1904

It closes issue #1898 and includes an update to be able to run the cellular automata on a single face tile. It also includes an update to ensure that consistent decomposition between the FV3 domain and the higher resolution CA domain.

@jkbk2004 jkbk2004 added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ci Jenkins CI: ORT build/test on docker container labels Sep 27, 2023
@FernandoAndrade-NOAA
Copy link
Collaborator

Looks like there are failures on the jenkins ci side due to allocation being exceeded again, running manually on hera.

@zach1221
Copy link
Collaborator

Looks like there are failures on the jenkins ci side due to allocation being exceeded again, running manually on hera.

I'll work with platform today to get the issue fixed.

@pjpegion
Copy link
Collaborator Author

I was traveling yesterday. Do you still need me to update .gitmodules?

@FernandoAndrade-NOAA
Copy link
Collaborator

I was traveling yesterday. Do you still need me to update .gitmodules?

Yes please go ahead and revert .gitmodules and update the hash for stochastic as the sub PR is already merged in

@pjpegion
Copy link
Collaborator Author

ok, done

@BrianCurtis-NOAA
Copy link
Collaborator

WCOSS has 2 timeouts, but there is a known machine issue with slowness. I've verified with more time the tests pass, but will not be making any changes to the UFS code at this time.

@FernandoAndrade-NOAA
Copy link
Collaborator

Ok this should be ready for merging, continuing with final reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins-ci Jenkins CI: ORT build/test on docker container No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
9 participants