Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nine 3D arrays from CLM Lake and remove an incorrect dependency in rt.conf #1926

Conversation

SamuelTrahanNOAA
Copy link
Collaborator

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
    • There are no reviews yet.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
    • LOG: committed to logs/RegressionTests_hera.log in branch
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

  1. Removes nine 3D arrays from the CLM Lake model and adds one 2D array. The arrays are all constant, so they don't need to be stored.
  2. Removes an incorrect dependency of conus13km_2threads on conus13km_control in rt.conf.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

Blocking Dependencies

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.

Regression Tests:

  • Changes are expected to the following tests:
Most tests that run CLM Lake. Expand for full list.
COMPILE | rrfs | intel | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_RAP_sfcdiff,FV3_HRRR,FV3_RRFS_v1beta,FV3_RRFS_v1nssl,FV3_HRRR_gf,FV3_HRRR_c3 -D32BIT=ON | | fv3 |
RUN | hrrr_control                                      | - wcoss2 noaacloud         | baseline |
RUN | hrrr_control_qr                                   | - wcoss2 noaacloud         |          |
RUN | hrrr_control_decomp                               | - wcoss2 noaacloud         |          |
RUN | hrrr_control_2threads                             | - wcoss2 noaacloud         |          |
RUN | hrrr_control_restart                              | - wcoss2 noaacloud         |          | hrrr_control
RUN | hrrr_control_restart_qr                           | - wcoss2 noaacloud         |          | hrrr_control_qr
RUN | hrrr_gf                                           | - noaacloud                | baseline |
RUN | hrrr_c3                                           | - noaacloud                | baseline |

COMPILE | atm_debug_dyn32 | intel | -DAPP=ATM -DDEBUG=ON -D32BIT=ON -DCCPP_SUITES=FV3_HRRR,FV3_GFS_v16,FV3_GFS_v16_csawmg,FV3_GFS_v16_ras,FV3_GFS_v17_p8,FV3_GFS_v15_thompson_mynn_lam3km,FV3_RAP,FV3_RAP_unified_ugwp,FV3_RAP_cires_ugwp,FV3_RAP_flake,FV3_RAP_clm_lake,FV3_RAP_noah,FV3_RAP_sfcdiff,FV3_RAP_noah_sfcdiff_cires_ugwp,FV3_RRFS_v1beta | - noaacloud  | fv3 |
RUN | hrrr_control_debug                                | - noaacloud                  | baseline |

COMPILE | rrfs_dyn32_phy32 | intel | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_HRRR -D32BIT=ON -DCCPP_32BIT=ON |  - noaacloud  | fv3 |
RUN | hrrr_control_dyn32_phy32                          | - noaacloud                  | baseline |
RUN | hrrr_control_qr_dyn32_phy32                       | - noaacloud                  |          |
RUN | hrrr_control_2threads_dyn32_phy32                 | - noaacloud                  |          |
RUN | hrrr_control_decomp_dyn32_phy32                   | - noaacloud                  |          |
RUN | hrrr_control_restart_dyn32_phy32                  | - noaacloud                  |          | hrrr_control_dyn32_phy32
RUN | hrrr_control_restart_qr_dyn32_phy32               | - noaacloud                  |          | hrrr_control_qr_dyn32_phy32

COMPILE | rrfs_dyn32_phy32_faster | intel | -DAPP=ATM -DFASTER=ON -DCCPP_SUITES=FV3_HRRR -D32BIT=ON -DCCPP_32BIT=ON | - noaacloud  | fv3 |
RUN | conus13km_control             | - noaacloud                                      | baseline |
RUN | conus13km_2threads            | - noaacloud                                      |          |
RUN | conus13km_restart_mismatch    | - noaacloud                                      | baseline | conus13km_control

COMPILE | rrfs_dyn32_phy32_debug | intel | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_HRRR,FV3_HRRR_gf -D32BIT=ON -DCCPP_32BIT=ON -DDEBUG=ON | - noaacloud  | fv3 |
RUN | hrrr_control_debug_dyn32_phy32                    | - noaacloud                  | baseline |
RUN | conus13km_debug                                   | - noaacloud                  | baseline |
RUN | conus13km_debug_2threads                          | - noaacloud                  |          |
RUN | conus13km_radar_tten_debug                        | - noaacloud                  | baseline |


COMPILE | rrfs | gnu | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_RAP_sfcdiff,FV3_HRRR,FV3_RRFS_v1beta,FV3_HRRR_gf,FV3_HRRR_c3 -D32BIT=ON | + hera cheyenne hercules | fv3 |
RUN | hrrr_control                                      | + hera cheyenne hercules            | baseline |
RUN | hrrr_control_qr                                   | + hera cheyenne hercules            |          |
RUN | hrrr_control_2threads                             | + hera cheyenne hercules            |          |
RUN | hrrr_control_decomp                               | + hera cheyenne hercules            |          |
RUN | hrrr_control_restart                              | + hera cheyenne hercules            |          | hrrr_control
RUN | hrrr_control_restart_qr                           | + hera cheyenne hercules            |          | hrrr_control_qr
RUN | hrrr_gf                                           | + hera cheyenne hercules            | baseline |

COMPILE | atm_dyn32_debug | gnu | -DAPP=ATM -D32BIT=ON -DDEBUG=ON | + hera cheyenne hercules | fv3 |
RUN | hrrr_control_debug                                | + hera cheyenne hercules            | baseline |

COMPILE | rrfs_dyn32_phy32 | gnu | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_HRRR -D32BIT=ON -DCCPP_32BIT=ON | + hera cheyenne hercules | fv3 |
RUN | hrrr_control_dyn32_phy32                          | + hera cheyenne hercules            | baseline |
RUN | hrrr_control_qr_dyn32_phy32                       | + hera cheyenne hercules            |          |
RUN | hrrr_control_2threads_dyn32_phy32                 | + hera cheyenne hercules            |          |
RUN | hrrr_control_decomp_dyn32_phy32                   | + hera cheyenne hercules            |          |
RUN | hrrr_control_restart_dyn32_phy32                  | + hera cheyenne hercules            |          | hrrr_control_dyn32_phy32
RUN | hrrr_control_restart_qr_dyn32_phy32               | + hera cheyenne hercules            |          | hrrr_control_qr_dyn32_phy32
RUN | conus13km_control                                 | + hera cheyenne hercules            | baseline |
RUN | conus13km_2threads                                | + hera cheyenne hercules            |          |
RUN | conus13km_restart_mismatch                        | + hera cheyenne hercules            | baseline | conus13km_control

COMPILE | atm_dyn32_phy32_debug | gnu | -DAPP=ATM -D32BIT=ON -DCCPP_32BIT=ON -DDEBUG=ON | + hera cheyenne hercules | fv3 |
RUN | hrrr_control_debug_dyn32_phy32                    | + hera cheyenne hercules            | baseline |
RUN | conus13km_debug                                   | + hera cheyenne hercules            | baseline |
RUN | conus13km_debug_2threads                          | + hera cheyenne hercules            |          |
RUN | conus13km_radar_tten_debug                        | + hera cheyenne hercules            | baseline |

Libraries

  • Not Needed
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@SamuelTrahanNOAA SamuelTrahanNOAA changed the title Remove nine 3D variables from CLM Lake and remove an incorrect dependency in rt.conf Remove nine 3D arrays from CLM Lake and remove an incorrect dependency in rt.conf Sep 27, 2023
SamuelTrahanNOAA added a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Sep 29, 2023
jkbk2004 pushed a commit that referenced this pull request Oct 3, 2023
…sics, and string length mismatch in dycore (plus PR #1913, #1917, and #1926) (#1893)

* GFDL_atmos_cubed_sphere: consistent string lengths in array

* stop FV3_HRRR_c3 from crashing with gnu debug

* 1hr forecast limit for conus13km_debug_qr

* fv3atm: bug fix from Dusan to recover_fields crash

* disable conus13km_debug_qr_gnu due to 25% failure rate on Hera

* FV3 dycore: initialize srf_wnd_var2 and tracers_var3 arrays

* enable conus13km_debug_qr_gnu

* Fix race condition in GFS_phys_time_vary.fv3.F90 error detection

* More bug fixes to GFS_phys_time_vary.fv3.F90:
1. detect empty errmsg from subroutines
2. Initialize err variables in set_soilveg.f, which is called from GFS_phys_time_vary.fv3.F90

* ccpp-physics: initialize errmsg & errflg in noahmp_tables.f90

* ccpp-physics: only read h2odata, ozdata and noahmp table when they are needed

* "point to the dimension fix of smc for dust emission"

* FV3: more dycore bug fixes from GFDL_atmos_cubed_sphere PR 285

* merge #1926

* merge GFDL_atmos_cubed_sphere #276

* bugfix: 12hr hrrr tests

* add GAEA rocoto support

* fv3: merge GF radar fixes

* check that baseline directory exists and is non-empty

---------

Co-authored-by: Haiqin.Li <Haiqin.Li@noaa.gov>
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Oct 3, 2023

Merged with #1893

@jkbk2004 jkbk2004 closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants