Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow instantaneous SW and LW fluxes to be used when cpllnd=.true. (re-opening #1943) #1947

Merged

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Oct 18, 2023

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

Allows SW and LW instantaneous export fields for when coupled to external land component.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

Blocking Dependencies

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@DeniseWorthen DeniseWorthen added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Oct 18, 2023
junwang-noaa
junwang-noaa previously approved these changes Oct 19, 2023
@zach1221
Copy link
Collaborator

@BrianCurtis-NOAA I think we should move here next. 1920 & 1923 need more time.

@zach1221 zach1221 added the jenkins-ci Jenkins CI: ORT build/test on docker container label Oct 19, 2023
@epic-cicd-jenkins
Copy link
Collaborator

Jenkins-ci ORTs passed

@BrianCurtis-NOAA
Copy link
Collaborator

BrianCurtis-NOAA commented Oct 20, 2023

Acorn can be skipped for the following reasons:

  • the same failures from the previous merged PR occur here as well.
  • most importantly, the spack-stack PR was run fully on Acorn with success.

We will temporarily halt Acorn support until the spack-stack PR is merged.

@FernandoAndrade-NOAA
Copy link
Collaborator

Alright in that case, this should be good to continue the merge process. I'll follow up on the sub PRs thanks.

@FernandoAndrade-NOAA
Copy link
Collaborator

Ok sub PRs are merged in, please update .gitmodules and commit hash, thank you.

@FernandoAndrade-NOAA FernandoAndrade-NOAA merged commit 001f6f1 into ufs-community:develop Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins-ci Jenkins CI: ORT build/test on docker container No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow instantaneous down LW and SW to be used by when cpllnd=true
8 participants