Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct documentation build failures & reflect switch to spack-stack #1950

Closed

Conversation

gspetro-NOAA
Copy link
Contributor

@gspetro-NOAA gspetro-NOAA commented Oct 18, 2023

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below. (N/A)
  • I am confirming reviews are completed in ALL sub-component PR's. (N/A)
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
    • LOG: N/A - No tests required for documentation updates.
  • I have added the list of all failed regression tests to "Anticipated changes" section. (N/A)
  • I have filled out all sections of the template.

Description

This PR updates the documentation with information about the WM switch to spack-stack.
This PR also cures documentation build fails on ReadTheDocs.
See the docs build from my fork here: https://gsp-wm.readthedocs.io/en/text-release-doc/
Build passed: image

Linked Issues and Pull Requests

Closes Issue #1949 and #1951.

Subcomponent Pull Requests

N/A

Blocking Dependencies

N/A

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

None

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@gspetro-NOAA gspetro-NOAA changed the title Update documentation to reflect switch to spack-stack Update documentation to correct build failures & reflect switch to spack-stack Oct 18, 2023
@gspetro-NOAA gspetro-NOAA changed the title Update documentation to correct build failures & reflect switch to spack-stack Correct documentation build failures & reflect switch to spack-stack Oct 18, 2023
@gspetro-NOAA gspetro-NOAA marked this pull request as ready for review October 18, 2023 15:17
@jkbk2004
Copy link
Collaborator

merged with #1923

@jkbk2004 jkbk2004 closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants