Consider sea surface currents in air-sea flux calculation for ufs atmosphere-ocean coupling

[binli2337]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full RT suite (compared to current baselines) on either Hera/Derecho/Hercules AND have committed the log to my PR branch.
• Add list of all failed regression tests in "Regression Tests" section.

PR Information

Description

This PR adds capability of considering sea surface current's impact on air-sea flux calculation for atmosphere-ocean coupling.

Commit Message

Enable the capability of considering sea surface current's impact on air-sea flux calculation for atmosphere-ocean coupling. A namelist option is added to control whether or not to use this feature (default is off). Fixes #1975

Co-authored by: @binli2337, @BinLiu-NOAA, @WeiguoWang-NOAA, @BijuThomas-NOAA, @hyunsookkim-NOAA, @XuLi-NOAA, @MariaAristizabal-NOAA, @JohnSteffen-NOAA

Priority

• Critical Bugfix (This PR contains a critical bug fix and should be prioritized.)
• High (This PR contains a feature or fix needed for a time-sensitive project (eg, retrospectives, implementations))
  • Needed for HAFSv2 upgrade code freeze
• Normal

Blocking Dependencies

• requires Consider surface ocean current in air-sea flux calculation NOAA-EMC/fv3atm#755
• requires Include surface ocean current in the computation of air-sea fluxes NOAA-GFDL/GFDL_atmos_cubed_sphere#311
• requires Update to consider sea surface current in air-sea flux calculation ccpp-physics#155
• requires Update ccpp-physics in CMEPS to consider sea surface ocean current in air-sea flux computation  NOAA-EMC/CMEPS#107

Git Issues Fixed By This PR

• Closes Enable taking into account sea surface current in atmosphere-ocean coupling #1975
• Closes Consider surface ocean current in the computation of air-sea fluxes NOAA-EMC/fv3atm#753
• Closes Consider sea surface ocean current in the estimation of air-sea fluxes ccpp-physics#156
• Closes Downscaling sea surface current field from parent grid to nested grid NOAA-GFDL/GFDL_atmos_cubed_sphere#312
• Closes Update ccpp-physics used in CMEPS NOAA-EMC/CMEPS#106

Changes

Subcomponent (with links)

• AQM
• CDEPS
• CICE
• CMEPS
  • Update ccpp-physics in CMEPS to consider sea surface ocean current in air-sea flux computation  NOAA-EMC/CMEPS#107
• CMakeModules
• FV3
  • Consider surface ocean current in air-sea flux calculation NOAA-EMC/fv3atm#755
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Input data

• No changes are expected to input data.
• Changes are expected to input data:
  • New input data.
  • Updated input data.

Regression Tests:

• No changes are expected to any regression test.
• Changes are expected to the following tests:

FAILED REGRESSION TESTS

Libraries

• Not Needed
• Needed
  • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
  • Add issue link from JCSDA/spack-stack following this item

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[jkbk2004]

@binli2337 can you sync up branches? As we discussed, we will try to combine #2098 to this PR from physics PR level. I am moving to ufs-community/ccpp-physics#155 to follow up there.

[BinLiu-NOAA]

@binli2337 can you sync up branches? As we discussed, we will try to combine #2098 to this PR from physics PR level. I am moving to ufs-community/ccpp-physics#155 to follow up there.

@jkbk2004 This PR branch and all its submodules have been synced with their corresponding ufs-weather-model develop branch. Thanks!

[BinLiu-NOAA]

A quick follow-up is that, the full RT set went through on WCOSS2 successfully, confirming no answer changing for the baseline.

Meanwhile, a note is that, the gnv1_nested_intel test failed in the first try during result checking/comparing against baseline, however the second try of the gnv1_nested_intel test succeeded without issues. Another note is that, I encountered the similar issue (first try failed, second run succeeded) for this gnv1_nested_intel test while testing another PR branch.

With that, I think this PR/branch is ready to proceed for next steps. Thanks!

[DeniseWorthen]

@BinLiu-NOAA We need Logs from Hera committed to the PR branch before proceeding (Hera adds GNU compile/test).

[zach1221]

@BinLiu-NOAA We need Logs from Hera committed to the PR branch before proceeding (Hera adds GNU compile/test).

@DeniseWorthen I can run them, if needed to move forward. My ecflow seems to work ok on hera now.

[BinLiu-NOAA]

@BinLiu-NOAA We need Logs from Hera committed to the PR branch before proceeding (Hera adds GNU compile/test).

@DeniseWorthen I can run them, if needed to move forward. My ecflow seems to work ok on hera now.

Thanks, @zach1221!

[binli2337]

@DeniseWorthen Have you started the runs? I can do it.

[DeniseWorthen]

No, I have not started RTs (didn't think I needed to).

[BinLiu-NOAA]

@binli2337 and @DeniseWorthen, I just checked. And @zach1221 is currently running RTs on Hera for this PR. Thanks!

[zach1221]

@binli2337 and @DeniseWorthen, I just checked. And @zach1221 is currently running RTs on Hera for this PR. Thanks!

Yes, I have them going. A little more than halfway there.

[zach1221]

@binli2337 fyi, we're going to work PR #2098 currently and will work this one afterwards.

[zach1221]

Hera logs attached. No changes.

RegressionTests_hera.log

[zach1221]

@binli2337 can you please sync up your branch here? We'll begin testing against this PR next.

[BinLiu-NOAA]

@zach1221, wondering if this PR is ready for the final RT processing. Also, feel free to let us know if help is needed to run the full set of RTs on WCOSS2. Thanks!

[zach1221]

@zach1221, wondering if this PR is ready for the final RT processing. Also, feel free to let us know if help is needed to run the full set of RTs on WCOSS2. Thanks!

Hi, @BinLiu-NOAA sorry for the late reply. Yes, the tests are running. We're working to get them finished as soon as possible. Brian should be taking care of WCOSS tests.

[FernandoAndrade-NOAA]

In addition to cpld_debug_gfsv17_intel, the hafs_regional_atm_ocn_wav_intel test has also failed with a timeout on Jet. However, it should be noted the failure was properly reported on the test summary at the end.

[BinLiu-NOAA]

Much appreciated, @zach1221, @FernandoAndrade-NOAA, @BrianCurtis-NOAA! Hopefully, the RTs will go through smoothly. Thanks!

[zach1221]

Regression testing is complete. We can proceed with the merging process on ccpp-physics and cubed-sphere.
@binli2337 @BinLiu-NOAA

[DeniseWorthen]

@binli2337 cmeps is merged 8cd4a32

[zach1221]

@binli2337 fv3atm is merged now as well. NOAA-EMC/fv3atm@8db821c

[binli2337]

@zach1221 I will merge FV3 now.

[binli2337]

It is ready for review. Thanks!