Add extra variables to get ice temperature for marine DA

[JessicaMeixner-NOAA]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full RT suite (compared to current baselines) on either Hera/Derecho/Hercules AND have committed the log to my PR branch:
  RegressionTests_hera.log
• Add list of all failed regression tests in "Regression Tests" section.

PR Information

Description

The marine DA needs ice temperature as model output from CICE. This PR adds the requested variables and @guillaumevernieres confirmed these are the variables needed:
f_sitempsnic f_sitemptop and f_sitempbot

Commit Message

Add ice temperature in CICE output

Priority

• Critical Bugfix (This PR contains a critical bug fix and should be prioritized.)
• High (This PR contains a feature or fix needed for a time-sensitive project (eg, retrospectives, implementations))
• Normal

Blocking Dependencies

No

Git Issues Fixed By This PR

Changes

Subcomponent (with links)

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Input data

• No changes are expected to input data.
• Changes are expected to input data:
  • New input data.
  • Updated input data.

Regression Tests:

• No changes are expected to any regression test.
• Changes are expected to the following tests:
  cpld_control_gfsv17_iau_intel The ice history file changes with the added variables. I have confirmed that creating a new baseline, all tests pass.

Libraries

• Not Needed
• Needed
  • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
  • Add issue link from JCSDA/spack-stack following this item

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[JessicaMeixner-NOAA]

Here's the log comparing with new baseline:
RegressionTests_hera_newbaseline.log

[DeniseWorthen]

@JessicaMeixner-NOAA Why is a new baseline required? We don't compare ice history output in the RTs.

[JessicaMeixner-NOAA]

@JessicaMeixner-NOAA Why is a new baseline required? We don't compare ice history output in the RTs.

@DeniseWorthen there's one ice history file: https://github.com/ufs-community/ufs-weather-model/blob/develop/tests/tests/cpld_control_gfsv17_iau#L49

[DeniseWorthen]

@JessicaMeixner-NOAA Thanks. I forgot that Jun added both ocean and ice history comparisons to that test.