Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GFDL Land Model 4.0 #2146

Draft
wants to merge 151 commits into
base: develop
Choose a base branch
from

Conversation

JustinPerket
Copy link

@JustinPerket JustinPerket commented Feb 23, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Introduces the GFDL Land Model version 4.0 (LM4.0) with NUOPC Driver. Functional but not scientically valid for Data Atmosphere mode with CDEPS.

Adds these two nested submodules:

  • LM4-NUOPC driver - hosted at github.com/NOAA-GFDL/LM4-NUOPC-driver. NUOPC cap/driver for LM4

Commit Message:

* UFSWM - Adds GFDL Land Model version 4 (LM4) as a component model, functional in Data Atmosphere mode
  * CMEPS - Small modifications for coupling of LM4
 * LM4-NUOPC driver - new model component hosted at github.com/NOAA-GFDL/LM4-NUOPC-driver. NUOPC Cap for LM4
   * LM4.0 - submodule of LM4 NUOPC driver, hosted at https://github.com/NOAA-GFDL/LM4/
 

Priority:

  • Normal

Git Tracking

UFSWM:

  • No current Issue (TBD?)

Sub component Pull Requests:

New Sub components:


Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR should not affect existing Tests/Baselines.

Input data Changes:

LM4 copies input data files from @[INPUTDATA_LM4] , a temporary development variable for path to GFDL data. It is set in rt.sh for these machines:

  • Gaea: INPUTDATA_LM4=${INPUTDATA_LM4:-/gpfs/f5/gfdl/world-shared/cmip6/datasets/CM4/common}
  • Hera: INPUTDATA_LM4=${INPUTDATA_LM4:-/scratch2/GFDL/gfdlscr/Justin.Perket/cmip6/datasets/CM4/common}
  • Orion: INPUTDATA_LM4=${INPUTDATA_LM4:-/work/noaa/gfdlscr/pdata/gfdl/cmip6/datasets/CM4/common}

UFS's grid_spec.nc references aXl mosaic tile files that are required by LM4, but are not included in current UFS input paths.
Therefore in development, this untars @[INPUTDATA_LM4]/c96_grid/c96_OM4_025_grid_No_mg_drag_v20160808.tar for conistent grid_spec.nc and related files

Additionally, the following files are needed by LM4:

  @[INPUTDATA_LM4]/c96_LM4/c96_topo_rough_land.nc.tar
  @[INPUTDATA_LM4]/common_LM4/biodata.nc
  @[INPUTDATA_LM4]/common_LM4/cover_type.nc
  @[INPUTDATA_LM4]/common_LM4/geohydrology.nc
  @[INPUTDATA_LM4]/common_LM4/geohydrology_table_2a2n.nc 
  @[INPUTDATA_LM4]/common_LM4/ground_type.nc
  @[INPUTDATA_LM4]/common_LM4/landuse.nc
  @[INPUTDATA_LM4]/common_LM4/soil_brdf.nc
  @[INPUTDATA_LM4]/common_LM4/soil_type_hwsd_5minute.nc -> ./INPUT/soil_type.nc

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

…ile datetime stamp shifted forward by slow timestep. This then reflects behavior GFDL FMS coupler
Add in computed gust like in FMS standalone LM4.0

In LM4.0 driver:
- Set ex_q_surf with ex_tr_surf(1,isphum) before and after surface flux, remove test printing.
- Remove sfc_boundary_layer debugging, including gust overwrite
- Add update_atmos_model_down subroutine to lm4_driver module for gust calculation. Read in atmos_prescr_nml. Fix flux_exchange_nml not being read in
- updated documentation

input_datm_lm4.nml.IN now allows for using computed gust in lm4 surface flux
@JustinPerket JustinPerket changed the title Feature/lm4 Add GFDL Land Model 4.0 Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant