Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a few JEDI-related aliases into the fd_ufs.yaml file+Add option to specify fv3atm history and inline post files output directory #2254 + Bump jinja2 from 3.1.3 to 3.1.4 in /doc/UsersGuide #2270 #2215

Merged
merged 19 commits into from
May 9, 2024

Conversation

fabiolrdiniz
Copy link
Contributor

@fabiolrdiniz fabiolrdiniz commented Mar 29, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

For the JEDI-UFS integration, several aliases are needed in fd_ufs.yaml. This PR adds the missing aliases.

Add new model_configure option (fv3atm_output_dir) to specify directory in which all history and inline post files will be saved.

Commit Message:

* UFSWM - Add several aliases in `fd_ufs.yaml` needed for JEDI-UFS. Add new model_configure option (fv3atm_output_dir) to specify directory in which all fv3atm history and inline post files will be saved.
  * FV3 -  Add new model_configure option (fv3atm_output_dir) to specify directory in which all history and inline post files will be saved.

Priority:

  • Normal

Git Tracking

UFSWM

ISSUES

MERGED PR'S

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@climbfuji
Copy link
Collaborator

@jkbk2004 JCSDA needs this PR - I can pick it up where it is and get it ready. Can we add this to the commit queue for tomorrow's meeting?

@climbfuji climbfuji marked this pull request as ready for review May 3, 2024 02:39
@climbfuji climbfuji requested a review from jkbk2004 May 3, 2024 02:39
@climbfuji
Copy link
Collaborator

@jkbk2004 I ran rt.sh for this PR on Derecho for the latest commit (9299932) - which is up to date with develop - and all regression tests passed against the existing baseline. test_changes.list submitted as requested. PR is ready!

@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 7, 2024

@fabiolrdiniz can you sync up the branch one more time? We can start working on this pr. Note that we are considering to combine in #2253 and #2254.

@jkbk2004 jkbk2004 changed the title Adding a few JEDI-related aliases into the fd_ufs.yaml file Adding a few JEDI-related aliases into the fd_ufs.yaml file+Add option to specify fv3atm history and inline post files output directory #2254 May 7, 2024
@jkbk2004 jkbk2004 changed the title Adding a few JEDI-related aliases into the fd_ufs.yaml file+Add option to specify fv3atm history and inline post files output directory #2254 Adding a few JEDI-related aliases into the fd_ufs.yaml file+Add option to specify fv3atm history and inline post files output directory #2254 + Bump jinja2 from 3.1.3 to 3.1.4 in /doc/UsersGuide #2270 May 7, 2024
@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 7, 2024

@DusanJovic-NOAA I combined in #2254 to this pr.

@zach1221
Copy link
Collaborator

zach1221 commented May 7, 2024

I'll do a prelim test of the combined PR on hercules.

Tests all passed.
RegressionTests_hercules.log

@zach1221 zach1221 added No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels May 8, 2024
@zach1221
Copy link
Collaborator

zach1221 commented May 8, 2024

@FernandoAndrade-NOAA @BrianCurtis-NOAA I think we can begin testing here.

@zach1221 zach1221 added hercules-RT Run Hera regression testing orion-RT derecho-RT Run regression tests on Derecho and removed hercules-RT Run Hera regression testing orion-RT derecho-RT Run regression tests on Derecho labels May 8, 2024
@zach1221
Copy link
Collaborator

zach1221 commented May 9, 2024

Regression testing is complete. We can proceed with merging process.

@BrianCurtis-NOAA
Copy link
Collaborator

The template is incomplete. We're probably not using that commit message. When we merge many PR's into one it's important to make sure the template is also updated.

@zach1221
Copy link
Collaborator

zach1221 commented May 9, 2024

The template is incomplete. We're probably not using that commit message. When we merge many PR's into one it's important to make sure the template is also updated.

Commit message is updated.

@DusanJovic-NOAA
Copy link
Collaborator

The template is incomplete. We're probably not using that commit message. When we merge many PR's into one it's important to make sure the template is also updated.

Commit message is updated.

Please do not use ampersand sign in commit message

@BrianCurtis-NOAA
Copy link
Collaborator

The template is incomplete. We're probably not using that commit message. When we merge many PR's into one it's important to make sure the template is also updated.

Commit message is updated.

I've made edits, it should look more like this. we don't need all the extra information. I had to bring in issues we're closing with this PR from other PR's

@jkbk2004 jkbk2004 merged commit 85d73f2 into ufs-community:develop May 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
8 participants