-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of python script to add yaml-based test option #2278
base: develop
Are you sure you want to change the base?
Conversation
@BrianCurtis-NOAA @zach1221 @FernandoAndrade-NOAA FYI: I am turning on py and yaml linting options with this pr. |
OK, It's good practice to address warnings if possible, I see this:
|
from my perspective, the capabilities introduced here will help facilitate the integration of cases into a ufs htf, especially through the project options and flexibility enabled through yaml-python interface. |
Why not push this to uw tools instead of ufs-weather-model if orthogonal and intended for different tests and hierarchical testing framework? |
@NickSzapiro-NOAA Triggering whole regression test or vertical ufs tests from uw tools? It's a bit oversimplification. uw tools just facilitates a workflow system with parsing and setting up model configuration options. uw tool itself is not a workflow system. In UFS system, all development approaches are based on git flow not trunk-based approach. In this case, allowing another test functionality is actually good option in a sense of strangulation not to tangle with internal test system that code managers actively use on daily basis. So people can adopt or test new test features in gradual approaches. Once all satisfies, new features can be transferred to internal test system. |
@NickSzapiro-NOAA I am not sure about the requirements Jong has on the updates for the RT framework itself, but as far as HTF goes, I think it could be a great use of uwtools outside the RT framework to provide some configurable use cases. In that case, a user could build ufs-weather-model with their favorite settings, and then use uwtools to run their experiment. I ❤️ this idea! |
@christinaholtNOAA @NickSzapiro-NOAA Feel free to add UFS-WM tests to UW tools side and let us know when the new test options are available. We will use new test feature. |
Commit Queue Requirements:
Description:
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: