Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CICE end of run restart file capability+Update submodule FV3/atmos_cubed_sphere to fix a typo when printing out the nest grid corner locations #2323+Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UsersGuide #2329 + Orion changes for switch to new OS - Rocky-9 #2336 #2324

Conversation

dpsarmie
Copy link
Collaborator

@dpsarmie dpsarmie commented Jun 13, 2024

The CICE hash includes changed that will add the ability to write a restart file at the end of the run via the CMEPS configuration. This is in conjunction with a similar PR for the MOM6 model.

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR adds changes to the CICE submodule that allows for the creation of restart files at the end of the model run. This option is controlled in CMEPS via the write_restart_at_endofrun config option. This should allow for files to be written when the interval write time does not sync up with the total run time (ex. 27h forecast with 12h restart write intervals). This change was also done in another PR for MOM6.

Commit Message:

  * CICE - Adds restart write capability at the end of a run for CICE
  * FV3 - 
    * atmos_cubed_sphere - Update submodule FV3/atmos_cubed_sphere to fix a typo when printing out the nest grid corner locations
    * doc/UsersGuide/requirements.txt: Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.1 to 2.2.2.
    * Orion Spack stack modulefile update: Rocky-9
    * update detect_machine.sh: hercules

Priority:

  • Normal

Git Tracking

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

The CICE hash includes changed that will add the ability to write
a restart file at the end of the run via the CMEPS configuration.
This is in conjunction with a similar PR for the MOM6 model.
@dpsarmie dpsarmie added enhancement New feature or request No Baseline Change No Baseline Change labels Jun 13, 2024
@dpsarmie dpsarmie self-assigned this Jun 13, 2024
@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Jun 13, 2024

@dpsarmie Since at this point we'd have the capability to turn this for CMEPS, CICE and MOM6, we'd want to add a configurable setting to the various ufs.configure files. We can set that false by default, but that will allow the G-W to set it optionally .true.

There were multiple regression tests that did not have the
write_restart_at_endofrun option in the ufs.configure file.
Now that the write_restart_at_endofrun has been fixed in MOM6
and CICE, this option will be added to the ufs.configure files.
This does not cause change the RT baselines.
Adding the write_restart_at_endofrun option to other
regression test ufs.configure files that were missed
with the previous commit.
@dpsarmie
Copy link
Collaborator Author

@dpsarmie Since at this point we'd have the capability to turn this for CMEPS, CICE and MOM6, we'd want to add a configurable setting to the various ufs.configure files. We can set that false by default, but that will allow the G-W to set it optionally .true.

@DeniseWorthen That makes sense. The change will be rolled into this PR. The ufs.configure files have been changed and retested everything for completeness.

@DeniseWorthen
Copy link
Collaborator

@dpsarmie We need this as a configurable variable, so that users can set it true if they need to but we can use false in the RT.

This will change the write_restart_at_endofrun variable to
@[WRITE_ENDOFRUN_RESTART] to allow for user configuration. Default
has been set to .false. in default_vars.sh.
@DeniseWorthen
Copy link
Collaborator

@dpsarmie Thanks for making those changes. I think this is ready.

2 minor typos fixed in default_var script comments
@dpsarmie
Copy link
Collaborator Author

@DeniseWorthen Ok great! The RTs just finished on Hercules using the latest version of the branch and it was good to go on my end.

@jkbk2004
Copy link
Collaborator

@dpsarmie can you sync up branches? We like to start working on this pr. Can you combine in #2323 to this pr? Just need to points to @BinLiu-NOAA 's fv3 feature branch: NOAA-EMC/fv3atm#847

@dpsarmie
Copy link
Collaborator Author

@jkbk2004 I just want ahead and edited the gitmodules file to point to Bin's branch and brought the PR up to date. Let me know if you need anything else.

@FernandoAndrade-NOAA
Copy link
Collaborator

FernandoAndrade-NOAA commented Jun 20, 2024

@dpsarmie I'm not seeing Bin's latest commit in your FV3, only the latest fv3 develop commit of 07c26d1 which does not look like it contains Bin's newer a6fdff7 for atmos cubed sphere. Could you double check your hashes for fv3/atmos cubed sphere?

4fd5f0e for FV3 and a6fdff7 for atmos cubed sphere should be present

@dpsarmie
Copy link
Collaborator Author

dpsarmie commented Jun 21, 2024

@FernandoAndrade-NOAA Sorry, I had it in 1561588 but then overwrote it back with the e5b9eed commit. Looks like Jong made the update to the hash. Thanks Jong!

@jkbk2004
Copy link
Collaborator

@dpsarmie it looks reverted. Let me fix one more time. I will update urllib3 version as well: #2329

@jkbk2004 jkbk2004 changed the title Add CICE end of run restart file capability Add CICE end of run restart file capability+Update submodule FV3/atmos_cubed_sphere to fix a typo when printing out the nest grid corner locations #2323+Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UsersGuide #2329 Jun 21, 2024
@jkbk2004
Copy link
Collaborator

All looks good. @FernandoAndrade-NOAA This PR is ready for testing. @zach1221 I will check if I can run on Orion. @BrianCurtis-NOAA FYI

@jkbk2004
Copy link
Collaborator

As some debugging is needed, I propose to move to #2290 (priority PR) first. @zach1221 @FernandoAndrade-NOAA @BrianCurtis-NOAA FYI

@zach1221
Copy link
Collaborator

@zach1221 I'd like to copy over one of your other debug test rundirs. Where are they located?

Apologies for the delay. Please see rundir below for failed case.
/glade/derecho/scratch/zshrader/FV3_RT/rt_96451/cpld_debug_gfsv17_intel

@DeniseWorthen
Copy link
Collaborator

@zach1221 I think you misunderstood. You said that you could confirm that the other debug tests ran OK on derecho. Where are those rundirs located?

@zach1221
Copy link
Collaborator

@zach1221 I think you misunderstood. You said that you could confirm that the other debug tests ran OK on derecho. Where are those rundirs located?

Sure, location is here.
/glade/derecho/scratch/zshrader/FV3_RT/rt_10335

@BrianCurtis-NOAA
Copy link
Collaborator

@jkbk2004 We are OK disabling that test on Derecho and moving forward. Please create an issue with all we've learned about the problem so we can follow up on fixing it.

@jkbk2004
Copy link
Collaborator

@dpsarmie @zach1221 can we create git issue to follow on derecho cpld_debug_gfsv17_intel failure ? We can turn off the case on derecho and go for merging. @BrianCurtis-NOAA @DeniseWorthen would it be ok?

@jkbk2004
Copy link
Collaborator

@BrianCurtis-NOAA Thanks!

@jkbk2004
Copy link
Collaborator

#2338

@jkbk2004
Copy link
Collaborator

Sorry for the delay. But we can move on for merging process with cpld_debug_gfsv17_intel disabled on derecho.

@DeniseWorthen
Copy link
Collaborator

@jkbk2004 We don't have a derecho log yet.

@FernandoAndrade-NOAA
Copy link
Collaborator

Ok I think we're set to continue, the failed test in the Derecho log has already been disabled in a previous commit.

@DeniseWorthen
Copy link
Collaborator

CICE has been merged hash 9452de8

@FernandoAndrade-NOAA FernandoAndrade-NOAA merged commit e784814 into ufs-community:develop Jun 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
6 participants