Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dumpfields=true option by using ESMF_FieldBundleWrite #2355

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Jul 3, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR fixes dumpfields=true option in FV3 which can be used to write all coupling fields (from import and export states) by using updated version of ESMF's ESMF_FieldBundleWrite function instead of old ESMFIO_Write.

Commit Message:

* UFSWM - Fix dumpfields=true option in FV3 by using ESMF_FieldBundleWrite
  * FV3 - Fix dumpfields=true option by using ESMF_FieldBundleWrite

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@DusanJovic-NOAA DusanJovic-NOAA marked this pull request as draft July 3, 2024 13:46
@DusanJovic-NOAA DusanJovic-NOAA self-assigned this Jul 3, 2024
@DusanJovic-NOAA DusanJovic-NOAA added the No Baseline Change No Baseline Change label Jul 3, 2024
@DusanJovic-NOAA
Copy link
Collaborator Author

"Pull Request Tests / Check if repos are up to date (pull_request)" failed with this error:

Run helper_id=$(cat ~/id_file)
cat: /home/runner/id_file: No such file or directory
Error: Process completed with exit code 1.

This check should be either fixed or disabled, This test error is misleading.

@DusanJovic-NOAA
Copy link
Collaborator Author

Regression test passed on Hera:
RegressionTests_hera.log

@DusanJovic-NOAA DusanJovic-NOAA marked this pull request as ready for review July 8, 2024 13:03
@DusanJovic-NOAA
Copy link
Collaborator Author

Regression test passed on WCOSS2:
RegressionTests_wcoss2.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dumpfields=true fails in module_fcst_grid_comp.F90 for coupled model
1 participant