Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix to update with cubed sphere bug fix #2362

Open
wants to merge 39 commits into
base: develop
Choose a base branch
from

Conversation

jkbk2004
Copy link
Collaborator

@jkbk2004 jkbk2004 commented Jul 11, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Random crash for the following regional cases: a floating-point exception in subroutine a2b_ord2 in FV3/atmos_cubed_sphere/model/a2b_edge.F90

  • conus13km_debug_intel
  • conus13km_debug_2threads_intel
  • hafs_regional_storm_following_1nest_atm_ocn_debug_intel

Commit Message:

* UFSWM - 
  * FV3 - 
    * ccpp-physics - 
    * atmos_cubed_sphere - bug fix to address debug mode crashes caused by floating-point exception in subroutine a2b_ord2 in model/a2b_edge.F90

Priority:

  • Critical Bugfix: Reason

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@jkbk2004
Copy link
Collaborator Author

Cubed sphere bug report at: NOAA-GFDL/GFDL_atmos_cubed_sphere#346 @BrianCurtis-NOAA @zach1221 @FernandoAndrade-NOAA FYI. I will come list of crashing cases and turn off them.

@SamuelTrahanNOAA
Copy link
Collaborator

The crashing cases I'm seeing are to test the current operational HAFS and proposed operational RRFS in debug mode. Turning them off really isn't an option. The developer needs to fix this, and the broken changes should be reverse-merged.

@jkbk2004
Copy link
Collaborator Author

@XiaqiongZhou-NOAA The crashing issue points to #2327.

@jkbk2004
Copy link
Collaborator Author

jkbk2004 commented Jul 11, 2024

@XiaqiongZhou-NOAA OOPS! sorry the crashing issue is with #2327 you are correct. we don't need to turn off the SFS case.

@jkbk2004 jkbk2004 changed the title Hotfix to update cubed sphere hash Hotfix to update with cubed sphere bug fix Jul 12, 2024
@jkbk2004 jkbk2004 added the bug Something isn't working label Jul 12, 2024
@jkbk2004 jkbk2004 added No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Jul 12, 2024
@jkbk2004
Copy link
Collaborator Author

@BrianCurtis-NOAA @zach1221 @FernandoAndrade-NOAA This PR is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants