UW-16: As a model user, I want to configure a field table file for the model with a YAML config object. #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check on other platforms and receive feedback Adds config_field_table to generate a field table from YAML config. Uses modified Prototype from uw-203. Will update once 203 PR complete
Config_field_table remapped to existing FieldTableConfig Work from UW-203 incorporated and placeholders removed FieldTableConfig now applies a Jinja template to a loaded YAML config, rather than mapping file dump formats Debugging ongoing
directly. Edited the reference table to remove comments and removed unused files. Also fixed some issues in the YAML test config
WeirAE
requested review from
benjamin-cash,
christinaholtNOAA,
fgabelmannjr,
nbharwani11 and
elcarpenter
as code owners
|
Will sync #154 updates first before merging |
christinaholtNOAA
requested changes
Feb 17, 2023
FieldTableConfig formatting. Added variable formatting but should be replaced by proper justified columns eventually
…into UW-16_test
Closed
christinaholtNOAA
approved these changes
Feb 21, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Completed the FieldTableConfig method in config.py to take a YAML config object and generate an appropriately formatted field_table file, as well as an associated test. Fixes issue #152
Type of change
How Has This Been Tested?
Checklist