Multicomponent ICs/BCs #1224

endJunction · 2016-05-30T07:52:31Z

Introduce variable_id to get multivariable/multicomponent processes set up correctly with their ICs and BCs. Also see the Tests/Data, where <component_value_0> is used for example for the second component instead of <value>. Other ideas to mark the components are welcome.

The uniform initial conditions for multicomponent variable can be given in the form

<values>0.5 0.7 0.9</values>

for a three component variable.

Not implemented and explicitly marked as such is the reading of the multicomponent boundary conditions.

bilke · 2016-05-30T09:04:50Z

ProcessLib/Process.h

+                // an negative value of the vector size or the matrix dimension.
+                // To assign the initial value for the ghost entries, the
+                // negative indices of the ghost entries are restored to zero.
+                // checked hereby.


Wrong indent, dont change comment

endJunction · 2016-06-04T23:18:55Z

Jenkins, test this please!

I forgot to push Tests/Data.

ogsbot · 2016-06-05T11:47:35Z

Jenkins: OGS-6/Gui/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Win-PRs/1861/

chleh · 2016-06-06T06:58:13Z

ProcessLib/InitialCondition.cpp

 {
    config.checkConfParam("type", "Uniform");

-    auto value = config.getConfParam<double>("value");


Why not keep "value" as the option for single-component process variables and only use "values" for multi-component? ✅

chleh · 2016-06-06T07:21:04Z

@endJunction: I only found the change value → values in Tests/Data. Does the description text of this PR have to be updated?

chleh · 2016-06-06T07:21:51Z

NumLib/DOF/LocalToGlobalIndexMap.h

    {
+        auto const c = global_component(variable_id, component_id);


rename to getGlobalComponent() ? ✅

chleh · 2016-06-06T07:30:38Z

👍

wenqing · 2016-06-06T08:19:48Z

NumLib/DOF/LocalToGlobalIndexMap.h

+    std::size_t global_component(int const variable_id,
+                                 int const component_id) const
+    {
+        return _variable_component_offsets[variable_id] + component_id;


There are two ways add components to global vectors, i.e. BY_COMPONENT, or BY_LOCATION. It sounds that this is only for BY_COMPONENT.

I probably do not understand you. The global_component() (or getGlobalComponent() now) is simply calculating the global_component_id which would be used to access the actual DOF table. Here nothing is added or modified.

I see. It gets component id.

ogsbot · 2016-06-06T11:47:55Z

Jenkins: OGS-6/Linux-PRs-dynamic failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs-dynamic/240/

ogsbot · 2016-06-06T11:51:23Z

Jenkins: OGS-6/Linux-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Linux-PRs/2016/

ogsbot · 2016-06-06T11:52:44Z

Jenkins: OGS-6/Gui/Win-PRs failed: https://svn.ufz.de:8443/job/OGS-6/job/Gui/job/Win-PRs/1864/

endJunction · 2016-06-08T21:36:51Z

Had to rebase because of the merges. The only new thing is the small documentation attempt.

norihiro-w · 2016-06-14T17:12:31Z

Though it's not a point in this PR, why not add getID() to ProcessVariable? As far as I saw this PR, it can shorten code at many places.

endJunction · 2016-06-14T19:30:56Z

Regarding the ProcessVariable::getID():
Short answer here, long answer to be discussed, it's a good idea too, but:
Currently that id is stored and managed in the DOF table (see ctor of the LocalToGlobalIndexMap). Storing the ids outside would require additional code outside the DOF table. But also, as you mentioned, can reduce code when accessing that field.

endJunction · 2016-06-14T19:32:25Z

Sorry for the fifth rebase or so, but the ufz/master is changing fast in incompatible ways... The last commits address Norihiros comments.

norihiro-w · 2016-06-14T19:58:18Z

👍

TomFischer · 2016-06-15T06:08:52Z

👍

Update the constructors, getGlobalIndex(), and meshGetSubsets() to include the variable_id. The global component offsets for each variable are stored in the _variable_component_offset.

Variable and component ids are ints.

When creating a new MeshProperty the number of components was not passed further.

Now implemented for UniformIC.

No need to pass the Node and then fetch its id.

If it is not available the default case is <values>.

ogsbot · 2020-06-19T12:29:35Z

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

endJunction added the WIP 🏗️ label May 30, 2016

bilke reviewed May 30, 2016
View reviewed changes

endJunction force-pushed the MulticomponentICsBCs branch 2 times, most recently from 10074d6 to d8214ec Compare May 31, 2016 17:54

endJunction added WIP 🏗️ and removed WIP 🏗️ labels May 31, 2016

endJunction force-pushed the MulticomponentICsBCs branch 2 times, most recently from dacf531 to d5ecfae Compare June 4, 2016 23:04

endJunction force-pushed the MulticomponentICsBCs branch from d5ecfae to 2e007f9 Compare June 5, 2016 11:35

endJunction force-pushed the MulticomponentICsBCs branch from 2e007f9 to c3c82a1 Compare June 5, 2016 12:15

endJunction removed the WIP 🏗️ label Jun 5, 2016

chleh reviewed Jun 6, 2016
View reviewed changes

wenqing reviewed Jun 6, 2016
View reviewed changes

endJunction force-pushed the MulticomponentICsBCs branch from 6d7a88d to db11cdb Compare June 6, 2016 11:39

endJunction force-pushed the MulticomponentICsBCs branch 2 times, most recently from e08a109 to 0804b7b Compare June 8, 2016 21:32

endJunction force-pushed the MulticomponentICsBCs branch from 3e641dd to 71a8ee8 Compare June 14, 2016 19:31

TomFischer added please rebase and removed please review labels Jun 15, 2016

endJunction force-pushed the MulticomponentICsBCs branch from 71a8ee8 to 06fbd4f Compare June 15, 2016 08:37

endJunction merged commit 7d0b660 into ufz:master Jun 15, 2016

endJunction deleted the MulticomponentICsBCs branch June 15, 2016 09:18

TomFischer removed the please rebase label Jun 15, 2016

endJunction and others added 17 commits June 15, 2016 10:37

[AsmL] Add variable_id to LocalToGlobalIdxMap.

016db28

Update the constructors, getGlobalIndex(), and meshGetSubsets() to include the variable_id. The global component offsets for each variable are stored in the _variable_component_offset.

[PL] Use int for var/component ids in NeumannBC.

4c2b184

[PL] Add UniformDirichletBC ctor.

ba1d792

[PL] Store component ids in DirichletBcs.

8c1b9e0

[PL] Split UniformDirichletBC.cpp. No changes.

da1379b

[PL] Change initialize()'s arguments type.

76395ac

Variable and component ids are ints.

[PL] ProcessVar: Add n_components for MeshProperty

c6ba12d

When creating a new MeshProperty the number of components was not passed further.

[PL] Multicomponent initial conditions.

ccd58c1

Now implemented for UniformIC.

[PL] Update Process for multicomponent/var IC/BCs.

5560f29

[T] Update Tests/Data.

7eec7e6

[PL] Use node_id for getting IC values.

eae5f32

No need to pass the Node and then fetch its id.

[PL] Read of single component ic using <value>.

4c778f4

If it is not available the default case is <values>.

[PL] Comment on creation/initialization of bcs.

5d30c45

Changelog.

2dd9932

Documentation initial_condition/Uniform/values.

639f1d2

[PL] Explicit UniformInitialCondition ctor.

02a0b77

[PL] Store GeoObject& in ProcessVar and BCs.

06fbd4f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multicomponent ICs/BCs #1224

Multicomponent ICs/BCs #1224

endJunction commented May 30, 2016 •

edited

bilke May 30, 2016

endJunction commented Jun 4, 2016 •

edited

ogsbot commented Jun 5, 2016

chleh Jun 6, 2016 •

edited by endJunction

chleh commented Jun 6, 2016

chleh Jun 6, 2016 •

edited by endJunction

chleh commented Jun 6, 2016

wenqing Jun 6, 2016

endJunction Jun 6, 2016 •

edited

wenqing Jun 6, 2016

ogsbot commented Jun 6, 2016

ogsbot commented Jun 6, 2016

ogsbot commented Jun 6, 2016

endJunction commented Jun 8, 2016

norihiro-w commented Jun 14, 2016

endJunction commented Jun 14, 2016

endJunction commented Jun 14, 2016 •

edited

norihiro-w commented Jun 14, 2016

TomFischer commented Jun 15, 2016

ogsbot commented Jun 19, 2020

		{
		auto const c = global_component(variable_id, component_id);

Multicomponent ICs/BCs #1224

Multicomponent ICs/BCs #1224

Conversation

endJunction commented May 30, 2016 • edited

bilke May 30, 2016

Choose a reason for hiding this comment

endJunction commented Jun 4, 2016 • edited

ogsbot commented Jun 5, 2016

chleh Jun 6, 2016 • edited by endJunction

Choose a reason for hiding this comment

chleh commented Jun 6, 2016

chleh Jun 6, 2016 • edited by endJunction

Choose a reason for hiding this comment

chleh commented Jun 6, 2016

wenqing Jun 6, 2016

Choose a reason for hiding this comment

endJunction Jun 6, 2016 • edited

Choose a reason for hiding this comment

wenqing Jun 6, 2016

Choose a reason for hiding this comment

ogsbot commented Jun 6, 2016

ogsbot commented Jun 6, 2016

ogsbot commented Jun 6, 2016

endJunction commented Jun 8, 2016

norihiro-w commented Jun 14, 2016

endJunction commented Jun 14, 2016

endJunction commented Jun 14, 2016 • edited

norihiro-w commented Jun 14, 2016

TomFischer commented Jun 15, 2016

ogsbot commented Jun 19, 2020

endJunction commented May 30, 2016 •

edited

endJunction commented Jun 4, 2016 •

edited

chleh Jun 6, 2016 •

edited by endJunction

chleh Jun 6, 2016 •

edited by endJunction

endJunction Jun 6, 2016 •

edited

endJunction commented Jun 14, 2016 •

edited