Mesh partitioning tool #1238
Mesh partitioning tool #1238
Conversation
|
Maybe your tool fits better in Applications/Utils/ModelPreparation? |
|
@TomFischer Sounds good. Should I move the existing files of Applications/Utils/ModelPreparation to a new subdirectory, say ComputeNodeArea? By this the hierarchy of ModelPreparation will become as |
|
@wenqing Keep it flat. Just add the new tool in the ModelPreparation folder. |
| add_definitions(-DBUILD_WITH_METIS) | ||
| include(${CMAKE_SOURCE_DIR}/Applications/Utils/ModelPreparation/PartitionMesh/MetisSetup.cmake) | ||
| endif() | ||
| endif() |
There was a problem hiding this comment.
Maybe this part should be more general and not be bound to a specific tool. Something like this:
If metis submodule was checked out then
- include
MetisSetup.cmake - include
ModelPreparation/PartitionMesh(in Utils-directory)
There was a problem hiding this comment.
@bilke How to get the status in CMake that a submodule has been checkout?
|
I could not follow the code after the line 180 or so. I recommend to split the very long loop over the partitions into several smaller standalone routines, which fit into a screen. |
|
@endJunction That function will be rewritten according to your last comment. |
@wenqing Please, could you add the label for work in progress? |
| { | ||
| os << elem->getNodeIndex(j) + 1 <<" "; | ||
| } | ||
| os << std::endl; |
There was a problem hiding this comment.
std::endl can be slow, because it always flushes. Better use "\n".
wenqing
force-pushed
the
pmesh_tool
branch
2 times, most recently
from
70b06f1
to
970e4f0
Compare
|
👍 |
| #include <tclap/CmdLine.h> | ||
|
|
||
| #ifdef _MSC_VER | ||
| #include <windows.h> |
There was a problem hiding this comment.
Is it correct that windows.h is only included when using VisualStudio compiler? What about gcc under windows os?
|
OK. After fixing the windows.h include this is to be rebased and merged. |
…one unused cmd arguement
…orrected some typos
|
Rebased. Note there is a branch of pmesh_tool in ogs-data repository for this PR. |
|
OpenGeoSys development has been moved to GitLab. |
Added the mesh partitioning tool as a utility of ogs6.
Usage:
With a cmake option of UTILS_PARTMESH_BUILD_WITH_METIS, the source code of metis can be compiled into the executable file.Added the gitbub repository of metis
https://github.com/scibuilder/metis.git