Material model for fracture deformation #1434

norihiro-w · 2016-09-23T12:30:55Z

This PR adds two models for fracture deformation, linear elastic and Mohr-Coulomb.

Remarks

Mohr-Coulomb model is limited to 2D case
Fixed-size Eigen matrix/vectors are not considered. let me know if it's really important...

wenqing

👍

wenqing · 2016-09-23T13:33:27Z

MaterialLib/FractureModels/CreateLinearElasticIsotropic.cpp

+    config.checkConfigParameter("type", "LinearElasticIsotropic");
+    DBUG("Create LinearElasticIsotropic material");
+
+    // Youngs modulus


wenqing · 2016-09-23T13:33:43Z

MaterialLib/FractureModels/CreateLinearElasticIsotropic.cpp

+    DBUG("Create LinearElasticIsotropic material");
+
+    // Youngs modulus
+    auto& Kn = ProcessLib::findParameter<double>(


not necessary. the variable is only passed to MaterialProperties constructor.

wenqing · 2016-09-23T13:34:14Z

MaterialLib/FractureModels/CreateLinearElasticIsotropic.cpp

+
+    DBUG("Use '%s' as Kn parameter.", Kn.name.c_str());
+
+    // Poissons ratio


endJunction · 2016-09-26T09:44:35Z

@nagelt Could you have a look onto the material models please?

bilke · 2016-09-26T14:24:09Z

I guess we are hitting this Qt bug. I also guess the workaround would be to add the proposed #ifndef Q_MOC_RUN as a wrapper around the Boost include in MathTools.h.

norihiro-w · 2016-09-27T05:01:45Z

@bilke thanks! The workaround solved the error.

nagelt · 2016-09-27T07:46:54Z

Looks good to me. The code can be followed easily.

Fixed size matrices would be sigma/w of (displacement_dim x 1) and the various K/C matrices (displacement_dim x displacement_dim), right? So it's one implementation for MC (2) and two for linear elastic (2,3). @endJunction coming back to Nori's question: How much do we need fixed size when you look at our standard M implementations?

Aside from that I have no further comments on the content.

chleh

Only minor things from my side.

Eigen::Ref maybe should be discussed.
Regarding fixed-size Eigen matrices we probably should find a common policy at some point. @endJunction only uses fixed-size, if I remember correctly, and here there are only dynamic-size matrices.

chleh · 2016-09-27T07:44:25Z

MathLib/MathTools.h

@@ -17,7 +17,9 @@
 #include <omp.h>
 #endif

+#ifndef Q_MOC_RUN // to avoid Qt bug, https://bugreports.qt.io/browse/QTBUG-22829


Maybe add a comment that this is Qt4 specific? ✅
From the link above:

Until you port your code to Qt5 [...]

chleh · 2016-09-27T07:45:36Z

MaterialLib/FractureModels/CreateLinearElasticIsotropic.h

+#ifndef MATERIALLIB_FRACTURE_CREATELINEARELASTICISOTROPIC_H_
+#define MATERIALLIB_FRACTURE_CREATELINEARELASTICISOTROPIC_H_
+
+#include "ProcessLib/Utils/ProcessUtils.h"  // required for findParameter


Please move to cpp file. ✅

chleh · 2016-09-27T07:48:43Z

MaterialLib/FractureModels/CreateMohrCoulomb.h

+#ifndef MATERIALLIB_FRACTURE_CREATEMOHRCOULOMB_H_
+#define MATERIALLIB_FRACTURE_CREATEMOHRCOULOMB_H_
+
+#include "ProcessLib/Utils/ProcessUtils.h"  // required for findParameter


Also: please move to cpp file. ✅

chleh · 2016-09-27T07:51:25Z

MaterialLib/FractureModels/FractureModelBase.h

+    virtual void computeConstitutiveRelation(
+            double const t,
+            ProcessLib::SpatialPosition const& x,
+            Eigen::Ref<Eigen::VectorXd const> w_prev,


Eigen::Ref wraps arbitrary Eigen expressions. I guess you really intend this. But should we really design our material models s.t. they take Eigen expressions as arguments rather than plain Eigen vectors/matrices?

I'm using Ref because it can simply take both fixed size and dynamic size Eigen objects. If the performance is important (I doubt because the number of fracture elements are not many), I can change it as Dima did in Solids::MechanicsBase.

Sounds like a cool idea. However, I am not entirely sure if it reduces complexity (fixed & dynamic at the same time) or increases it (now we have to deal with Eigen::Ref, too).
Maybe at some point in the future there should be a discussion about the matrix types used in material models.

chleh · 2016-09-27T07:53:58Z

MaterialLib/FractureModels/LinearElasticIsotropic.cpp

+    const int index_ns = DisplacementDim - 1;
+    C.setZero();
+    for (int i=0; i<index_ns; i++)
+        C(i,i) = _mp.shear_stiffness(t, x)[0];


Optimization idea: save _mp.shear_stiffness(t, x)[0] to a temporary outside the loop.

i would postpone optimization until we figure out its necessity.

chleh · 2016-09-27T07:57:41Z

MaterialLib/FractureModels/MohrCoulomb.h

+            Eigen::Ref<Eigen::VectorXd const> w,
+            Eigen::Ref<Eigen::VectorXd const> sigma_prev,
+            Eigen::Ref<Eigen::VectorXd> sigma,
+            Eigen::Ref<Eigen::MatrixXd> Kep) override;


Here the parameter is alled Kep does it have a slightly different meaning now than the C from the base class method?

"e" means elastic, "p" means plastic. Kep means it includes both elastic and plastic parts.

Thanks for the explanation.

chleh · 2016-09-27T07:59:43Z

MaterialLib/FractureModels/MohrCoulomb.cpp

+        Eigen::Ref<Eigen::VectorXd> sigma,
+        Eigen::Ref<Eigen::MatrixXd> Kep)
+{
+    if (DisplacementDim == 3)


Would it be more work to static_assert this and to not add a specialization for DisplacementDim == 3?

i am not sure if it works. static_assert means we don't compile fracture stuff at all for 3D, but other fracture model such as elastic one can work with 3D.

chleh · 2016-09-27T08:01:06Z

MaterialLib/FractureModels/MohrCoulomb.cpp

+    Eigen::MatrixXd Ke(2,2);
+    Ke.setZero();
+    Ke(0,0) = mat.Ks;
+    Ke(1,1) = mat.Kn;


Optimization idea: Maybe there is something possible with Eigen::MatrixXd::Diagonal(...) or similar.

chleh · 2016-09-27T08:01:32Z

MaterialLib/FractureModels/MohrCoulomb.cpp

+    }
+
+    // check shear yield function (Fs)
+    double const Fs = std::abs(sigma[0]) + sigma[1] * tan(mat.phi) - mat.c;


std::tan, also below. ✅

endJunction · 2016-09-28T12:05:13Z

MaterialLib/FractureModels/MohrCoulomb.h

+                P const& normal_stiffness, P const& shear_stiffness,
+                P const& friction_angle, P const& dilatancy_angle,
+                P const& cohesion)
+            : normal_stiffness(normal_stiffness), shear_stiffness(shear_stiffness),


Small improvement:
A warning is issued "declaration shadows a field of MaterialLib::Fracture::MohrCoulomb::MaterialProperties" for all constructor's arguments. I usually postfix the arguments with underscore: :white_check_mark:

MaterialProperties(P const& normal_stiffness_) : normal_stiffness(normal_stiffness_) {}

endJunction · 2016-09-28T12:09:27Z

MathLib/MathTools.h

+
+/// converts the given degrees to radians
+inline double to_radians(double degrees) {
+    return degrees*boost::math::constants::pi<double>()/180.;


FYI: There also is a direct pi/180 constant in boost called radians

thanks for the info. but i don't see a reason to change current code.

endJunction · 2016-09-28T12:21:26Z

MathLib/MathTools.h

+/// sign function
+template <typename T> int sgn(T val) {
+    return (T(0) < val) - (val < T(0));
+}


The sign function is already implemented in boost: #include <boost/math/special_functions/sign.hpp>
I'd prefer an existing function ✅

ogsbot · 2020-06-19T12:35:11Z

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

norihiro-w added the please review label Sep 23, 2016

wenqing reviewed Sep 23, 2016

View reviewed changes

norihiro-w force-pushed the fracture-model branch from 7c3c67b to 26e9312 Compare September 26, 2016 05:38

chleh approved these changes Sep 27, 2016

View reviewed changes

endJunction approved these changes Sep 28, 2016

View reviewed changes

endJunction added please rebase and removed please review labels Sep 28, 2016

Norihiro Watanabe and others added 16 commits September 28, 2016 16:03

add MaterialLib/FractureModels and its base class

2d68cd8

add LinearElasticIsotropic model for fractures

4bfd1fd

add sgn(), to_radians() in MathTools.h

341da31

add MohrCoulomb model for fractures

2046c69

add documentation to FractureModelBase

42426a4

use full names for Kn, Ks in config

fb3cd9d

add tests for fracture models

26c27df

replace #pragma once with include guard

2e1a245

use boost::math::constants::pi instead of M_PI

eb3d29a

surround Boost include with #ifndef Q_MOC_RUN

acfc543

fix MSVC errors

d59c4b5

specify Qt version making the trouble

73cb825

use std::tan

75dcff1

mv include of ProcessUtils.h to cpp files

cdae86a

postfix the arguments with underscore to avoid declaration shadows

565036d

use boost::math::sign()

f3ae8bd

norihiro-w force-pushed the fracture-model branch from a787f6c to f3ae8bd Compare September 28, 2016 14:03

norihiro-w merged commit 7373d48 into ufz:master Sep 28, 2016

norihiro-w deleted the fracture-model branch September 28, 2016 15:09

norihiro-w removed the please rebase label Sep 28, 2016

bilke added a commit to bilke/ogs that referenced this pull request Oct 13, 2016

[CMake] Minimum Eigen is 3.2.8 since ufz#1434.

b48ddeb

bilke added a commit to bilke/ogs that referenced this pull request Oct 13, 2016

[CMake] Minimum Eigen is 3.2.8 since ufz#1434.

3a69d05

bilke added a commit to bilke/ogs that referenced this pull request Oct 13, 2016

[CMake] Minimum Eigen is 3.2.8 since ufz#1434.

49c67f0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Material model for fracture deformation #1434

Material model for fracture deformation #1434

norihiro-w commented Sep 23, 2016 •

edited

Loading

wenqing left a comment

wenqing Sep 23, 2016

norihiro-w Sep 26, 2016

wenqing Sep 23, 2016

norihiro-w Sep 26, 2016

wenqing Sep 23, 2016

norihiro-w Sep 26, 2016

endJunction commented Sep 26, 2016

bilke commented Sep 26, 2016

norihiro-w commented Sep 27, 2016

nagelt commented Sep 27, 2016

chleh left a comment

chleh Sep 27, 2016 •

edited by norihiro-w

Loading

chleh Sep 27, 2016 •

edited by norihiro-w

Loading

chleh Sep 27, 2016 •

edited by norihiro-w

Loading

chleh Sep 27, 2016

norihiro-w Sep 27, 2016

chleh Sep 27, 2016

chleh Sep 27, 2016

norihiro-w Sep 27, 2016

chleh Sep 27, 2016

norihiro-w Sep 27, 2016

chleh Sep 27, 2016

chleh Sep 27, 2016

norihiro-w Sep 27, 2016

chleh Sep 27, 2016

chleh Sep 27, 2016 •

edited

Loading

norihiro-w Sep 27, 2016

chleh Sep 27, 2016 •

edited by norihiro-w

Loading

endJunction Sep 28, 2016 •

edited by norihiro-w

Loading

endJunction Sep 28, 2016

norihiro-w Sep 28, 2016

endJunction Sep 28, 2016 •

edited by norihiro-w

Loading

ogsbot commented Jun 19, 2020


		DBUG("Use '%s' as Kn parameter.", Kn.name.c_str());

		// Poissons ratio

Material model for fracture deformation #1434

Material model for fracture deformation #1434

Conversation

norihiro-w commented Sep 23, 2016 • edited Loading

wenqing left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

endJunction commented Sep 26, 2016

bilke commented Sep 26, 2016

norihiro-w commented Sep 27, 2016

nagelt commented Sep 27, 2016

chleh left a comment

Choose a reason for hiding this comment

chleh Sep 27, 2016 • edited by norihiro-w Loading

Choose a reason for hiding this comment

chleh Sep 27, 2016 • edited by norihiro-w Loading

Choose a reason for hiding this comment

chleh Sep 27, 2016 • edited by norihiro-w Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chleh Sep 27, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chleh Sep 27, 2016 • edited by norihiro-w Loading

Choose a reason for hiding this comment

endJunction Sep 28, 2016 • edited by norihiro-w Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

endJunction Sep 28, 2016 • edited by norihiro-w Loading

Choose a reason for hiding this comment

ogsbot commented Jun 19, 2020

norihiro-w commented Sep 23, 2016 •

edited

Loading

chleh Sep 27, 2016 •

edited by norihiro-w

Loading

chleh Sep 27, 2016 •

edited by norihiro-w

Loading

chleh Sep 27, 2016 •

edited by norihiro-w

Loading

chleh Sep 27, 2016 •

edited

Loading

chleh Sep 27, 2016 •

edited by norihiro-w

Loading

endJunction Sep 28, 2016 •

edited by norihiro-w

Loading

endJunction Sep 28, 2016 •

edited by norihiro-w

Loading