-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CTests #1619
Update CTests #1619
Conversation
endJunction
commented
Dec 15, 2016
•
edited
edited
- Using REQUIREMENTS keyword of the AddTest cmake macro to distinguish between test working (or not working) with lis/petsc.
- Move individual process' tests into corresponding folders.
- Small fixes.
b673aa4
to
3209732
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the indentation issue: ⏩
@@ -2,7 +2,6 @@ | |||
add_test(NAME ogs_no_args COMMAND ogs) | |||
set_tests_properties(ogs_no_args PROPERTIES WILL_FAIL TRUE) | |||
|
|||
if(NOT OGS_USE_MPI) | |||
# CUBE 1x1x1 GROUNDWATER FLOW TESTS | |||
foreach(mesh_size 1e0 1e1 1e2 1e3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After removing the if
-clause you should also adapt the indentation of the former content of the clauses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right. I have split the whole content in the last commit.
I'd like to merge it today. Any further comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
Add NOT OGS_USE_MPI to explicit requirements for the non-mpi tests. For the parallel tests require mpi.
3209732
to
b273f5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
OpenGeoSys development has been moved to GitLab. |