Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CTests #1619

Merged
merged 5 commits into from
Dec 20, 2016
Merged

Update CTests #1619

merged 5 commits into from
Dec 20, 2016

Conversation

endJunction
Copy link
Member

@endJunction endJunction commented Dec 15, 2016

  • Using REQUIREMENTS keyword of the AddTest cmake macro to distinguish between test working (or not working) with lis/petsc.
  • Move individual process' tests into corresponding folders.
  • Small fixes.

Copy link
Member

@bilke bilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the indentation issue: ⏩

@@ -2,7 +2,6 @@
add_test(NAME ogs_no_args COMMAND ogs)
set_tests_properties(ogs_no_args PROPERTIES WILL_FAIL TRUE)

if(NOT OGS_USE_MPI)
# CUBE 1x1x1 GROUNDWATER FLOW TESTS
foreach(mesh_size 1e0 1e1 1e2 1e3)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the if-clause you should also adapt the indentation of the former content of the clauses.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. I have split the whole content in the last commit.

@endJunction
Copy link
Member Author

I'd like to merge it today. Any further comments?

Copy link
Member

@TomFischer TomFischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Copy link
Member

@wenqing wenqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@endJunction endJunction merged commit af65aea into ufz:master Dec 20, 2016
@endJunction endJunction deleted the UpdateCTests branch December 20, 2016 09:08
@ogsbot
Copy link
Member

ogsbot commented Jun 19, 2020

OpenGeoSys development has been moved to GitLab.

See this pull request on GitLab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants